Add documentation for WordPress.DB.RestrictedClasses #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
reviewed
Jun 19, 2024
| ]]> | ||
| </standard> | ||
| <code_comparison> | ||
| <code title="Invalid: Using the object-orientated mysqli interface"> |
There was a problem hiding this comment.
All of the other code documentation files have the valid case first. Is there any reason this has the invalid cases first?
There was a problem hiding this comment.
I suspect that most remarks I left for #2453 will also apply to this sniff ?
jrfnl
added
Status: Awaiting feedback
Component: Core
Focus: DB
and removed
Status: Review ready
labels
|
@paulgibbs, I was just wondering if you'll have a chance to finish this off in the near future. It would be great if this PR could be included in the next WPCS release. If you haven't got time or lost interest, please let us know and we'll see if we can find someone to take over. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1722