Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSLKEYLOGFILE env to enable logging SSL keys in libwebrtc / borin… #1429

Open
wants to merge 1 commit into
base: wpe-2.38
Choose a base branch
from

Conversation

amol-virnodkar-infosys
Copy link

@amol-virnodkar-infosys amol-virnodkar-infosys commented Nov 21, 2024

…gssl

For debugging, it's sometimes useful to be able to decrypt captured TLS traffic. By setting SSLKEYLOGFILE env variable, it's possible to log secrets to a file, which can then be used for decryption.
But libwebrtc uses a separate TLS implementation, boringssl, which does not support it by default.

Add key logging in libwebrtc if the env is set.

See: https://boringssl.googlesource.com/boringssl/+/d28f59c27bac60d3206f0c302b7cb37f9cd88f43%5E%21/#F0
Original author: David Benjamin [email protected]

…gssl

For debugging, it's sometimes useful to be able to decrypt captured TLS traffic.
By setting SSLKEYLOGFILE env variable, it's possible to log secrets to a file,
which can then be used for decryption.
But libwebrtc uses a separate TLS implementation, boringssl, which does not support it by default.

Add key logging in libwebrtc if the env is set.

See: https://boringssl.googlesource.com/boringssl/+/d28f59c27bac60d3206f0c302b7cb37f9cd88f43%5E%21/#F0
Original author: David Benjamin <[email protected]>
@amol-virnodkar-infosys
Copy link
Author

amol-virnodkar-infosys commented Nov 21, 2024

Hi @philn
I updated the commit message with the credits to the original author. We have not used mitmproxy for debugging WebRTC. Please review the changes.

@philn
Copy link

philn commented Nov 21, 2024

Well maybe try mitmproxy, it has UDP/TLS support. If that works there's no need to patch boringssl.

@modeveci modeveci requested a review from philn November 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants