Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prominent https://webkit.org/ link to top page #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Contributor

Add prominent https://webkit.org/ link to top page

A developer/reader coming in to the https://docs.webkit.org/ site would
likely find it pretty useful to also browse directly to the top of the
https://webkit.org/ site and explore all the other information about WebKit
which that site provides.

But the existing https://docs.webkit.org/ site doesn’t include any link
directly to the top of the https://webkit.org/ site.

Among the specific things linked to on the https://webkit.org/ site,
developers are likely to find the Feature Status tab in the top menu
to be useful — since it includes links to the Standards Positions and
CSS Features pages, which docs.webkit.org doesn’t link to (and
probably doesn’t need to).

See also https://commits.webkit.org/267977@main

* docs/index.md: Added link to https://webkit.org/

A developer/reader coming in to the https://docs.webkit.org/ site would
likely find it pretty useful to also browse directly to the top of the
https://webkit.org/ site and explore all the other information about WebKit
which that site provides.

But the existing https://docs.webkit.org/ site doesn’t include any link
directly to the top of the https://webkit.org/ site.

Among the specific things linked to on the https://webkit.org/ site,
developers are likely to find the Feature Status tab in the top menu
to be useful — since it includes links to the Standards Positions and
CSS Features pages, which docs.webkit.org doesn’t link to (and
probably doesn’t need to).

See also https://commits.webkit.org/267977@main
@stwrt
Copy link
Member

stwrt commented Sep 18, 2023

I am wondering if we want to instead have a link to webkit.org at the bottom (next to the github / slack links).

This way it would be easily visible from any page.

This uses the Safari logo but would need to be changed to the WebKit
logo or something else.
@sideshowbarker
Copy link
Contributor Author

I am wondering if we want to instead have a link to webkit.org at the bottom (next to the github / slack links).

This way it would be easily visible from any page.

OK, I just now pushed a change which adds it there too — though for now just with the Safari logo.

I’m not familiar with the build/templating system at all, so I don’t know how to add an icon that’s not a fontawesome/brands icon.

I don’t know what icon other than the WebKit logo would be appropriate. But since docs.webkit.org also uses the WebKit logo, I’d wonder if just using the WebKit logo would make users assume the icon/image link is just a “home” link to the docs.webkit.org site rather than the webkit.org site.

Regardless, the icon/image link seems like maybe a too-subtle way, just on its own, to direct user attention to the webkit.org site. So I don’t think it needs to be an either/or — it seems like the docs.webkit.org site could have both the prose link at the top of the home page and the icon/image link in the footer. (That is, what’s now in the current patch in this PR branch.)

But if you think only the icon/image link in the footer is sufficient, I’m happy to update the patch.

@JonWBedard
Copy link
Member

OK, I just now pushed a change which adds it there too — though for now just with the Safari logo.

I know we don't want to link webkit.org to the Safari logo like that. The relationship between Safari and WebKit already confuses folks, we definitely want to keep webkit.org under the WebKit rather than Safari brand.

@karlcow
Copy link
Member

karlcow commented Sep 20, 2023

I know we don't want to link webkit.org to the Safari logo like that. The relationship between Safari and WebKit already confuses folks, we definitely want to keep webkit.org under the WebKit rather than Safari brand.

Probably yes.
There is a request it seems for a Font Awesome Icon for WebKit.
FortAwesome/Font-Awesome#4937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants