feat: upgrade discord.js v13 -> v14 #928
Conversation
WalkthroughThis update upgrades the discord.js dependency from ^13.17.1 to ^14.17.3. The changes revise import statements across the codebase to use specific modules, update event constants from uppercase to camel case, and replace deprecated classes (such as MessageEmbed) with their modern equivalents (EmbedBuilder). In addition, command option types and permission flags have been standardized using enums like ApplicationCommandOptionType and PermissionsBitField. Numerous event handler files, interaction commands, and utility functions have been refactored accordingly without altering the core control flow. Changes
Sequence Diagram(s)sequenceDiagram
participant D as Discord API
participant B as Bot
participant EH as Event Handler
participant DB as Database/Logger
D->>B: Emit Event (e.g., GuildCreate)
B->>EH: Route event to proper handler
EH->>DB: Process event, update logging/database
DB-->>EH: Acknowledge update
EH-->>B: Complete event processing
sequenceDiagram
participant U as User
participant D as Discord API
participant IH as Interaction Handler
participant R as Response
U->>D: Send command interaction
D->>IH: Forward interaction to Bot
IH->>IH: Process command using updated option types and builders
IH->>R: Generate response with EmbedBuilder
R-->>U: Deliver the response
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (13)
src/eventHandlers/UpdateGuildStatistics.js (1)
22-22: Update permission flags to use PermissionsBitField.The permission flags should be updated to use the new
PermissionsBitFieldflags from discord.js v14.Apply this diff to update the permission flags:
- if (channel.permissionsFor(this.bot.client.user).has(['MANAGE_CHANNELS', 'MANAGE_ROLES'])) { + if (channel.permissionsFor(this.bot.client.user).has([PermissionsBitField.Flags.ManageChannels, PermissionsBitField.Flags.ManageRoles])) {Don't forget to add the import at the top:
-import { Events } from 'discord.js'; +import { Events, PermissionsBitField } from 'discord.js';src/eventHandlers/AddGuildToDatabase.js (1)
29-29: Fix missing closing bracket in debug log.The debug logging statement is missing a closing bracket.
- this.logger.debug(`Joined guild ${guild} (${guild.id}`); + this.logger.debug(`Joined guild ${guild} (${guild.id})`);src/eventHandlers/DeleteChannel.js (1)
14-14: Update event constant to camelCase.For consistency with other files and discord.js v14, the event constant should be updated to camelCase.
- super(bot, 'handlers.deleteChannel', Events.CHANNEL_DELETE); + super(bot, 'handlers.deleteChannel', Events.ChannelDelete);src/eventHandlers/LogMemberBan.js (1)
33-33: Update channel type check to use ChannelType enum.The channel type check should use the new
ChannelTypeenum from discord.js v14 instead of the string literal.- if (logChannel && logChannel.type === 'GUILD_TEXT') { + if (logChannel && logChannel.type === ChannelType.GuildText) {Don't forget to add the import:
-import { Events } from 'discord.js'; +import { ChannelType, Events } from 'discord.js';src/eventHandlers/LogMemberRemove.js (1)
33-33: Update channel type check to use ChannelType enum.The channel type check should use the new
ChannelTypeenum from discord.js v14 instead of the string literal.- if (logChannel && logChannel.type === 'GUILD_TEXT') { + if (logChannel && logChannel.type === ChannelType.GuildText) {Don't forget to add the import:
-import { Events } from 'discord.js'; +import { ChannelType, Events } from 'discord.js';src/eventHandlers/LogMemberUnban.js (1)
34-34: Update channel type check to use ChannelType enum.The channel type check should use the new
ChannelTypeenum from discord.js v14 instead of the string literal.- if (logChannel && logChannel.type === 'GUILD_TEXT') { + if (logChannel && logChannel.type === ChannelType.GuildText) {Don't forget to add the import:
-import { Events } from 'discord.js'; +import { ChannelType, Events } from 'discord.js';src/eventHandlers/NotifyOwnerJoin.js (1)
36-40: Critical: Update deprecated guild.owner usage.The
guild.ownerproperty is deprecated in discord.js v14. Useguild.fetchOwner()instead.Apply this diff to fix the breaking change:
- guild.owner.send( + const owner = await guild.fetchOwner(); + owner.send( `${this.client.user.username} has been added ` + `to ${guild.name} and is ready\n Type ` + `\`${prefix}help\` for help` );- guild.owner.send( + const owner = await guild.fetchOwner(); + owner.send( `Your guild **${guild.name}** is over the bot-to-user ratio.\nGenesis will now leave.\nIf you want to keep using ${this.client.user.username} please invite more people or kick some bots.` );Also applies to: 42-44
src/eventHandlers/BulkMessageDeleteHandle.js (1)
35-35: Update channel type check for discord.js v14.The channel type check should be updated to use the new channel types in v14.
Apply this diff:
- if (channel?.type === 'text') { + if (channel?.type === 0) { // GUILD_TEXTsrc/eventHandlers/MessageDeleteHandle.js (1)
30-30: Update channel type check for discord.js v14.The channel type check should use the new
ChannelTypeenum from discord.js v14 instead of the string literal 'GUILD_TEXT'.Import ChannelType and update the check:
+import { Events, ChannelType } from 'discord.js'; - if (logChannel && logChannel.type === 'GUILD_TEXT') { + if (logChannel && logChannel.type === ChannelType.GuildText) {src/utilities/Webhook.js (1)
35-35: Fix undefinedthisreference and deprecated method usage.There are two issues in the code:
this.settingsis undefined as this is not a class methodwebhooks.array()is deprecated in discord.js v14Apply these fixes:
- await this.settings.deleteWebhooksForChannel(ctx.channel.id); + await ctx.settings.deleteWebhooksForChannel(ctx.channel.id); - if (webhooks.array().length > 0) { - [target] = webhooks.array(); + const webhookArray = Array.from(webhooks.values()); + if (webhookArray.length > 0) { + [target] = webhookArray;Also applies to: 54-55
src/interactions/channels/Templates.js (1)
59-59: Update channel type check to use new ChannelType enum.The channel type check uses the old string literal 'GUILD_VOICE'. In discord.js v14, channel types are defined in the ChannelType enum.
+import { ChannelType } from 'discord.js'; - if (channel && channel.type !== 'GUILD_VOICE') { + if (channel && channel.type !== ChannelType.GuildVoice) {src/interactions/channels/Rooms.js (1)
143-143: Use ChannelType enum for channel types.Replace string literals with the new
ChannelTypeenum from discord.js v14 for better type safety:- type: 'GUILD_CATEGORY', + type: ChannelType.GuildCategory, - type: 'GUILD_TEXT', + type: ChannelType.GuildText, - type: 'GUILD_VOICE', + type: ChannelType.GuildVoice,Add the import:
-import { ApplicationCommandOptionType, PermissionsBitField, EmbedBuilder } from 'discord.js'; +import { ApplicationCommandOptionType, PermissionsBitField, EmbedBuilder, ChannelType } from 'discord.js';Also applies to: 150-150, 160-160
src/utilities/CommonFunctions.js (1)
882-882: Use ChannelType enum for channel type comparison.Replace the string literal with the new
ChannelTypeenum from discord.js v14 for better type safety:- Array.from(message.guild.channels.cache.filter((channel) => channel.type === 'GUILD_TEXT')) + Array.from(message.guild.channels.cache.filter((channel) => channel.type === ChannelType.GuildText))Add the import:
-import { Collection, EmbedBuilder } from 'discord.js'; +import { Collection, EmbedBuilder, ChannelType } from 'discord.js';
🧹 Nitpick comments (7)
src/interactions/warframe/Builds.js (1)
440-458: Resolve potential scoping issues with declarations in switch-based logic.
Static analysis flags the declaration of navComponents and other variables as potentially accessible in unintended switch clauses. Consider wrapping them in a local block or declaring them within their specific case if necessary.Possible approach:
switch (something) { case 'example': { + const navComponents = new ActionRowBuilder({ + // ... + }); + // ... } // ... }🧰 Tools
🪛 Biome (1.9.4)
[error] 440-458: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
src/eventHandlers/AddChannelToDatabase.js (1)
16-16: Update JSDoc to use correct type reference.The JSDoc parameter type should be updated to reflect the new discord.js v14 type.
- * @param {Discord.channel} channel channel to add to the database + * @param {import('discord.js').Channel} channel channel to add to the databasesrc/eventHandlers/LogMemberRemove.js (1)
21-21: Fix typo in JSDoc comment.There's a typo in the JSDoc comment.
- * @param {Discord.Message} message member that was remvoed, left, or kicked + * @param {Discord.Message} message member that was removed, left, or kickedsrc/interactions/core/Ping.js (1)
54-55: Consider removing empty footer icon.The footer icon is set to a zero-width space character ('\u200B'). Since it's not displaying an actual icon, consider removing the icon_url property entirely.
footer: { - icon_url: '\u200B', text: `Uptime: ${timeDeltaToString(interaction.client.uptime)}`, },src/interactions/warframe/WhereIs.js (2)
23-24: Update JSDoc to reflect new types.The JSDoc comment still references the old
Discordnamespace. Update it to use the new types from discord.js v14.- * @type {Discord.ApplicationCommandData} + * @type {import('discord.js').ApplicationCommandData}
32-32: Update JSDoc parameter type.Update the interaction parameter type to use the new discord.js v14 type.
- * @param {Discord.CommandInteraction} interaction interaction to handle + * @param {import('discord.js').CommandInteraction} interaction interaction to handlesrc/notifications/Broadcaster.js (1)
1-1: Optimize imports for better maintainability.Since we're only using the type for JSDoc, we can use an import type statement instead.
-import Discord from 'discord.js'; // eslint-disable-line no-unused-vars +import type { Client, EmbedBuilder } from 'discord.js';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (44)
package.json(1 hunks)src/bot.js(4 hunks)src/embeds/BaseEmbed.js(2 hunks)src/eventHandlers/AddChannelToDatabase.js(2 hunks)src/eventHandlers/AddGuildToDatabase.js(2 hunks)src/eventHandlers/AssignDefaultRoles.js(2 hunks)src/eventHandlers/BulkMessageDeleteHandle.js(2 hunks)src/eventHandlers/DeleteChannel.js(2 hunks)src/eventHandlers/DeleteGuild.js(2 hunks)src/eventHandlers/DynamicVoiceHandler.js(2 hunks)src/eventHandlers/InteractionHandler.js(7 hunks)src/eventHandlers/JoinNotify.js(1 hunks)src/eventHandlers/LeaveNotify.js(1 hunks)src/eventHandlers/LogMemberBan.js(2 hunks)src/eventHandlers/LogMemberRemove.js(2 hunks)src/eventHandlers/LogMemberUnban.js(2 hunks)src/eventHandlers/MessageDeleteHandle.js(1 hunks)src/eventHandlers/NotifyOwnerJoin.js(2 hunks)src/eventHandlers/NotifyVulgarName.js(1 hunks)src/eventHandlers/Ready.js(2 hunks)src/eventHandlers/UpdateGuildStatistics.js(1 hunks)src/eventHandlers/WelcomeHandler.js(1 hunks)src/interactions/channels/Rooms.js(9 hunks)src/interactions/channels/Templates.js(1 hunks)src/interactions/core/About.js(2 hunks)src/interactions/core/Ping.js(3 hunks)src/interactions/custom/CustomCommands.js(1 hunks)src/interactions/fun/8ball.js(2 hunks)src/interactions/fun/Corgi.js(1 hunks)src/interactions/fun/Joke.js(1 hunks)src/interactions/tracking/Tracking.js(11 hunks)src/interactions/warframe/Builds.js(7 hunks)src/interactions/warframe/Calculator.js(2 hunks)src/interactions/warframe/LFG.js(5 hunks)src/interactions/warframe/Lookup.js(3 hunks)src/interactions/warframe/PriceCheck.js(2 hunks)src/interactions/warframe/WhatsIn.js(2 hunks)src/interactions/warframe/WhereIs.js(3 hunks)src/interactions/warframe/Worldstate.js(9 hunks)src/models/Interaction.js(1 hunks)src/notifications/Broadcaster.js(1 hunks)src/utilities/Collectors.js(8 hunks)src/utilities/CommonFunctions.js(8 hunks)src/utilities/Webhook.js(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/interactions/fun/Joke.js
🧰 Additional context used
🪛 Biome (1.9.4)
src/interactions/warframe/Builds.js
[error] 440-458: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
🔇 Additional comments (61)
src/eventHandlers/UpdateGuildStatistics.js (2)
1-1: LGTM! Import statement updated correctly.The change to import only the
Eventsmodule directly follows best practices and aligns with discord.js v14 patterns.
8-8: LGTM! Event constant updated correctly.The event constant has been properly updated to use the new camel case format (
Events.GuildMemberUpdate) as required by discord.js v14.Let's verify that we're using the correct event constant name:
✅ Verification successful
🌐 Web query:
What are the available event constants in discord.js v14?💡 Result:
Discord.js v14 uses an `Events` enum to provide event constants, replacing string-based event names from previous versions. Here are key event categories and their corresponding constants: ## Core Client Events - `ClientReady`: Emitted when client connects - `InteractionCreate`: Triggered for slash commands/components - `MessageCreate`: Replaces `message` event (fires on new messages) ## Guild Events - `GuildCreate`/`GuildDelete`: Server join/leave - `GuildMemberAdd`/`GuildMemberRemove`: Member joins/leaves - `GuildMemberUpdate`: Member changes (roles/nickname) - `GuildUpdate`: Server configuration changes ## Scheduled Event Handling - `GuildScheduledEventCreate`/`Delete`/`Update` - `GuildScheduledEventUserAdd`/`Remove` ## Voice Channel Events - `VoiceStateUpdate`: Voice connection changes - `VoiceServerUpdate`: Voice server updates ## Message Lifecycle - `MessageDelete`/`BulkDelete` - `MessageUpdate`: Message edits ## Thread Management - `ThreadCreate`/`Delete`/`Update` - `ThreadMembersUpdate`: Participants change - `ThreadMemberUpdate`: Individual member changes ## Reaction Handling - `MessageReactionAdd`/`Remove` - `MessageReactionRemoveAll`/`RemoveEmoji` **Key changes in v14:** 1. Use enum access instead of strings: ```javascript const { Events } = require('discord.js'); client.on(Events.MessageCreate, message => { ... }); ``` 2. Event name standardization: - All events use PascalCase (e.g., `messageCreate` → `MessageCreate`) - Deprecated events removed in favor of Gateway v9 equivalents[9] For a complete list, reference the official [`Events` enum](https://discord.js.org/docs/packages/discord.js/14.14.1/Events:Enum)[8] which contains 140+ documented events. Common patterns include Create/Delete/Update suffixes for resource lifecycle events and UserAdd/UserRemove for participation tracking[4][7]. Citations: - 1: https://discordjs.guide/creating-your-bot/event-handling - 2: https://www.youtube.com/watch?v=XqPQnSSAg68 - 3: https://discord.js.org/docs/packages/discord.js/14.14.1/Message:Class - 4: https://github.com/itsdrvgo/discord.js-v14-events-cheatsheet - 5: https://www.youtube.com/watch?v=Mug61R0cxRw - 6: https://www.youtube.com/watch?v=JEEcbVjLyr0 - 7: https://gist.github.com/Iliannnn/f4985563833e2538b1b96a8cb89d72bb - 8: https://discord.js.org/docs/packages/discord.js/14.14.1/Events:Enum - 9: https://discordjs.guide/additional-info/changes-in-v14 - 10: https://discord.js.org/docs/packages/discord.js/14.17.3
LGTM! Event constant verified
The updated event constant (
Events.GuildMemberUpdate) aligns perfectly with the discord.js v14 naming conventions as confirmed by the web query. No further changes are necessary.src/interactions/warframe/Builds.js (4)
141-141: Good use of updated enumerations for command option types.
Switching to ApplicationCommandOptionType.Subcommand, .String, and .Boolean ensures compatibility with discord.js v14. Nicely done.Also applies to: 146-146, 151-151, 159-159, 163-163, 170-170, 175-175, 182-182, 190-190, 195-195, 202-202, 209-209, 214-214
421-426: Clean transition to builders for select menus.
Using ActionRowBuilder and StringSelectMenuBuilder is correct for discord.js v14; no issues found.
517-517: Correct usage of the new interactionType property.
Replacing legacy constants with InteractionType.MessageComponent is consistent with discord.js v14.Also applies to: 526-526
559-559: Proper migration to new ButtonBuilder and ButtonStyle.
These lines correctly align with the v14 approach.Also applies to: 561-561, 563-563
src/interactions/tracking/Tracking.js (7)
42-42: Seamless migration from v13 constants to v14 standard enumerations.
Updating defaultMemberPermissions and type fields to PermissionsBitField.Flags.ManageGuild and ApplicationCommandOptionType.* ensures the commands remain aligned with the new API.Also applies to: 46-47, 50-51, 54-55, 60-61, 64-65, 68-69, 72-73, 76-77, 80-81, 84-85
207-218: Ternary-based creation of ActionRowBuilder & ButtonBuilder is correctly applied.
Switching from old MessageButton usage to ButtonBuilder with ButtonStyle.Secondary is correct for v14.
226-256: Dynamic creation of ActionRowBuilder & StringSelectMenuBuilder.
Using these builders instead of legacy message components avoids deprecation issues and is fully v14-compliant. Nicely done.
267-296: Unified button row creation with the new builder patterns.
Good job employing ButtonBuilder and ButtonStyle.* for each action. The approach is straightforward and clear.
305-306: Adoption of explicit interaction and component types.
Replacing old usage with interactionType: interaction.MESSAGE_COMPONENT and componentType: ComponentType.StringSelect is correct for v14.
360-361: Button collector changes align with v14.
Using interactionType: interaction.MESSAGE_COMPONENT and componentType: ComponentType.Button is accurate.
528-528: Properly escaping markdown and removing mentions.
Utils.escapeMarkdown and Utils.removeMentions mitigate unwanted markdown parsing while protecting user mentions.src/interactions/fun/Corgi.js (1)
15-15: Straightforward file usage.
Returning an array with the corgi image URL is a concise approach and is perfectly valid for attachable resources.src/embeds/BaseEmbed.js (1)
1-1: LGTM! Correctly migrated from MessageEmbed to EmbedBuilder.The changes align with discord.js v14 migration guide where MessageEmbed was replaced with EmbedBuilder.
Let's verify if any EmbedBuilder methods need updates:
Also applies to: 11-11
✅ Verification successful
🌐 Web query:
What are the breaking changes between MessageEmbed and EmbedBuilder in discord.js v14?💡 Result:
The transition from `MessageEmbed` to `EmbedBuilder` in discord.js v14 introduced several breaking changes aimed at improving consistency and validation: ## 1. **Class Renaming and Structure** - `MessageEmbed` was renamed to `EmbedBuilder`[4][7]. - All embed-related methods now return immutable objects when received from the API[4]. To modify existing embeds, use: ```javascript const modifiedEmbed = EmbedBuilder.from(receivedEmbed).setTitle('Updated Title'); ``` ## 2. **Method Updates** - **`.addField()` Removal**: Replaced with `.addFields()`, which accepts an array of field objects[4][9]: ```javascript // Old (v13) embed.addField('Name', 'Value', true); // New (v14) embed.addFields([{ name: 'Name', value: 'Value', inline: true }]); ``` - **`.setAuthor()`/`.setFooter()` Parameter Changes**: Now require objects with explicit properties[4]: ```javascript embed.setAuthor({ name: 'Author', iconURL: 'url' }); embed.setFooter({ text: 'Footer', iconURL: 'url' }); ``` ## 3. **Validation Enhancements** - Embeds must include at least one non-empty field[9]. - Empty/null values in fields or titles will trigger errors[9]. - Validators are enabled by default (disable via `disableValidators()` if needed)[4]. ## 4. **Immutable API Responses** Embeds retrieved from messages (`message.embeds`) cannot be directly modified. Use `EmbedBuilder.from()` to create editable instances[4]: ```javascript const receivedEmbed = message.embeds[0]; const editedEmbed = EmbedBuilder.from(receivedEmbed).setColor(0xFF0000); ``` ## 5. **Color Handling** The `.setColor()` method now strictly accepts valid `ColorResolvable` types (e.g., hex strings like `#FF0000`, integers like `0xFF0000`, or RGB arrays)[1][7]. These changes align embeds with discord.js v14’s broader API improvements, emphasizing type safety and validation[4][7]. Developers should update method calls and ensure all embed components adhere to Discord’s formatting rules to avoid errors. Citations: - 1: https://discordjs.guide/popular-topics/embeds - 2: https://www.youtube.com/watch?v=DB8a8i1pXUM - 3: https://www.youtube.com/watch?v=YkpBaeM_WSM - 4: https://discordjs.guide/additional-info/changes-in-v14 - 5: https://www.youtube.com/watch?v=YofueNFQEVw - 6: https://discord.js.org/docs/packages/discord.js/14.17.3/EmbedBuilder:Class - 7: https://www.youtube.com/watch?v=PhXBtLeUbsA - 8: https://discord.js.org/docs/packages/discord.js/14.14.0/EmbedBuilder:Class - 9: https://github.com/AnIdiotsGuide/discordjs-bot-guide/blob/master/first-bot/using-embeds-in-messages.md - 10: https://discord.js.org/docs/packages/discord.js/14.14.1/Embed:Class
EmbedBuilder migration verified.
The web query confirms that migrating from MessageEmbed to EmbedBuilder requires updating methods like addField (now addFields) as well as parameter adjustments for setAuthor and setFooter. Since the changes in BaseEmbed.js correctly update the import and extend the new EmbedBuilder—and there's no evidence of outdated method calls in this snippet—the update appears correct.src/eventHandlers/DeleteGuild.js (1)
1-1: LGTM! Correctly updated event constant to camelCase.The changes align with discord.js v14 migration guide where event constants were renamed to use camelCase.
Also applies to: 14-14
src/eventHandlers/AddGuildToDatabase.js (1)
1-1: LGTM! Correctly updated event constant to camelCase.The changes align with discord.js v14 migration guide where event constants were renamed to use camelCase.
Also applies to: 14-14
src/eventHandlers/DeleteChannel.js (1)
1-1: LGTM! Correctly updated to use ChannelType enum.The changes align with discord.js v14 migration guide where string literals for channel types were replaced with ChannelType enum.
Also applies to: 24-24
src/models/Interaction.js (1)
22-24: LGTM! Type annotations correctly updated for discord.js v14.The parameter and return type annotations have been properly updated to use explicit Discord namespace references, which aligns with discord.js v14's type system.
✅ Verification successful
🌐 Web query:
What are the breaking changes in discord.js v14 regarding Message and MessagePayload types?💡 Result:
Discord.js v14 introduced several breaking changes affecting `Message` and `MessagePayload` types. Here's a structured breakdown: --- ### **1. Component Renaming and Immutability** - **Components** (buttons, select menus) now use `Builder` suffixes: ```js // Before (v13) new MessageButton(); // After (v14) new ButtonBuilder(); ``` - **Components fetched from the API are immutable**. To modify them: ```js const editedButton = ButtonBuilder.from(receivedButton).setDisabled(true); ``` ### **2. MessageEmbed Changes** - `MessageEmbed` renamed to `EmbedBuilder`. - **Deprecated methods**: - `.addField()` ➔ Use `.addFields()` with an array: ```js new EmbedBuilder().addFields([{ name: 'Field', value: 'Value', inline: true }]); ``` ### **3. Select Menu Updates** - `MessageSelectMenu` ➔ `StringSelectMenuBuilder`. - **Method changes**: - `.addOption()` removed ➔ Use `.addOptions()` with an array. ### **4. Enum Formatting** - Enum values now use **PascalCase** instead of `SCREAMING_SNAKE_CASE`: ```js // Before ApplicationCommandOptionTypes.SUB_COMMAND; // After ApplicationCommandOptionType.SubCommand; ``` ### **5. Util Function Removals** - `Util.removeMentions()` ➔ Use `allowedMentions` in message options. - `Util.splitMessage()` ➔ Manual handling required. ### **6. API Version Upgrade** - Discord.js v14 uses **Discord API v10**, which enforces stricter type checks (e.g., enum parameters now require `number` types instead of strings). ### **7. Event Handling** - The `message` event ➔ Replaced by `messageCreate`. --- **Examples of Impact**: - **Before (v13)**: ```js const embed = new MessageEmbed().addField('Title', 'Content'); const button = new MessageButton().setLabel('Click'); ``` - **After (v14)**: ```js const embed = new EmbedBuilder().addFields([{ name: 'Title', value: 'Content' }]); const button = new ButtonBuilder().setLabel('Click'); ``` For more details on thread management or voice message support updates, refer to the full changelog[9][4]. Citations: - 1: https://discordjs.guide/whats-new - 2: https://discord.js.org/docs/packages/discord.js/14.14.1/Message:Class - 3: https://discord.js.org/docs/packages/discord.js/14.14.1/MessagePayload:Class - 4: https://github.com/discordjs/discord.js/blob/main/packages/discord.js/CHANGELOG.md - 5: https://www.youtube.com/watch?v=YkpBaeM_WSM - 6: https://www.youtube.com/watch?v=jntUHXiFB8g - 7: https://github.com/discordjs/discord.js/issues/10298 - 8: https://v15.discordjs.guide/additional-info/updating-from-v14 - 9: https://discordjs.guide/additional-info/changes-in-v14 - 10: https://gist.github.com/Iliannnn/f4985563833e2538b1b96a8cb89d72bb
LGTM! Type annotations correctly updated to reflect discord.js v14 changes.
The explicit use of Discord.CommandInteraction, Discord.CommandContext, and the updated return type (Promise<Discord.Message | Discord.MessagePayload>) aligns with the breaking changes in discord.js v14 related to Message and MessagePayload types. No functional changes are introduced, and the adjustments solely improve type safety in accordance with the new discord.js v14 standards.
src/interactions/warframe/PriceCheck.js (1)
1-1: LGTM! Command options correctly updated for discord.js v14.The changes properly implement the new ApplicationCommandOptionType enum from discord.js v14, replacing the old Types constant.
Also applies to: 14-14, 19-19
src/eventHandlers/AssignDefaultRoles.js (1)
1-1: LGTM! Event handler correctly updated for discord.js v14.The changes properly implement:
- Direct Events import
- Camel case event name (GuildMemberAdd)
- Correct GuildMember type
Also applies to: 15-15, 20-20
✅ Verification successful
🌐 Web query:
What are the breaking changes in discord.js v14 regarding event names and member types?💡 Result:
Discord.js v14 introduced several breaking changes related to event names and member handling. Here's a detailed breakdown: ## Event Name Changes - **`message` ➔ `messageCreate`**: The legacy message event was renamed to align with Discord API v10 terminology[4][5]. - **`interaction` ➔ `interactionCreate`**: All interaction handling now uses this updated event name[4][5]. - **Removed application command events**: - `applicationCommandCreate` - `applicationCommandDelete` - `applicationCommandUpdate`[4] - **New thread-related events**: - `threadCreate` - `threadUpdate` - `threadDelete` - `threadListSync`[5] Example of updated event usage: ```javascript // Old (v13) client.on('message', message => {}); // New (v14) client.on(Events.MessageCreate, message => {}); ``` ## Member Type Changes 1. **GuildMemberManager updates**: - Added `addRole()`/`removeRole()` methods for direct role management without caching[4] - New `fetchMe()` method to retrieve client's guild member[4] 2. **Role position handling**: ```javascript // Old guild.setRolePositions([{role: '123', position: 2}]); // New guild.roles.setPositions([{role: '123', position: 2}]); ``` 3. **Member tracking**: - The `guildMemberUpdate` event now provides more detailed change tracking[5] - New properties like `flags` added to GuildMember objects[4] Example of role change detection: ```javascript client.on(Events.GuildMemberUpdate, (oldMember, newMember) => { const addedRoles = newMember.roles.cache.difference(oldMember.roles.cache); const removedRoles = oldMember.roles.cache.difference(newMember.roles.cache); }); ``` These changes were implemented to better align with Discord API v10 specifications and improve type safety through enum-based constants like `GatewayIntentBits` and `Partials`. Developers must update their event listeners and member handling logic to use the new naming conventions and methods[4][10]. Citations: - 1: https://discordjs.guide/whats-new - 2: https://www.youtube.com/watch?v=pm8X8hzCcTI - 3: https://docs.botghost.com/getting-started/changelogs-2025/changelogs-2024 - 4: https://discordjs.guide/additional-info/changes-in-v14 - 5: https://gist.github.com/Iliannnn/f4985563833e2538b1b96a8cb89d72bb - 6: https://www.youtube.com/watch?v=MDdt35tXYEA - 7: https://github.com/Tolga1452/discord.js-v14-template/releases - 8: https://discordjs.guide/popular-topics/faq - 9: https://www.youtube.com/watch?v=sHksse4EUFU - 10: https://github.com/discordjs/discord.js/discussions/7380
LGTM! Event handler correctly updated for discord.js v14.
The updated changes—importing Events directly, using the camel case constant GuildMemberAdd, and switching to the correct GuildMember type—align perfectly with the breaking changes in discord.js v14 as confirmed by your web query.src/interactions/fun/8ball.js (1)
1-1: LGTM! Command options correctly updated for discord.js v14.The changes properly implement the new ApplicationCommandOptionType enum from discord.js v14, replacing the old Types constant.
Also applies to: 38-38
src/eventHandlers/AddChannelToDatabase.js (1)
21-39: LGTM! Channel type checks updated correctly.The channel type checks have been properly updated to use the new
ChannelTypeenum from discord.js v14.src/eventHandlers/WelcomeHandler.js (1)
1-1: LGTM! Event constant updated correctly.The changes align with discord.js v14's best practices:
- Direct import of Events from discord.js
- Updated event constant to camelCase (GuildMemberAdd)
Also applies to: 12-12
✅ Verification successful
🌐 Web query:
What are the event constant changes in discord.js v14?💡 Result:
Discord.js v14 introduced several significant changes to event handling and constants, primarily focusing on standardization and API consistency. Here are the key changes: ## Event Name Changes - **Deprecated Events Removed**: - `message` ➔ replaced by `messageCreate` - `interaction` ➔ replaced by `interactionCreate`[1][4][7] - Application command events (`applicationCommandCreate`, `applicationCommandUpdate`, etc.) were removed entirely[1][7]. - **Thread Handling**: The `threadMembersUpdate` event now returns three parameters: ```js client.on('threadMembersUpdate', (addedMembers, removedMembers, thread) => { ... }); ``` instead of just the thread[1][4]. --- ## Enum-Based Event Constants Events now use PascalCase enums instead of string literals: ```js // Old (v13) client.on('guildMemberAdd', () => { ... }); // New (v14) const { Events } = require('discord.js'); client.on(Events.GuildMemberAdd, () => { ... }); ``` Common enum replacements: | v13 String | v14 Enum | |---------------------|-----------------------------| | `'ready'` | `Events.ClientReady` | | `'interactionCreate'`| `Events.InteractionCreate` | | `'guildMemberAdd'` | `Events.GuildMemberAdd` | This change improves type safety and IDE autocompletion[1][4][7]. --- ## Parameter Changes - **Guild Member Updates**: ```js client.on(Events.GuildMemberUpdate, (oldMember, newMember) => { ... }); ``` Now provides both previous and current member states[4][9]. - **Voice Channel Handling**: The `.deleted` property was removed from voice state objects - use cache checks instead[1]. - **Message Components**: Component interaction parsing moved to dedicated methods: ```js interaction.isButton(); // Check if interaction is button-based interaction.isStringSelectMenu(); // Check for select menus ``` --- ## New Events Added - **Guild Scheduled Events**: ```js client.on(Events.GuildScheduledEventCreate, (event) => { ... }); client.on(Events.GuildScheduledEventUserAdd, (event, user) => { ... }); ``` - **Boost Tracking**: ```js client.on(Events.GuildMemberBoost, (member) => { ... }); client.on(Events.GuildMemberUnboost, (member) => { ... }); ``` Developers should update their codebase to use the new enum-based event constants and verify parameter signatures for modified events. The changes improve type safety and align Discord.js more closely with Discord's official API structure. Citations: - 1: https://discordjs.guide/additional-info/changes-in-v14 - 2: https://discordjs.guide/whats-new - 3: https://www.youtube.com/watch?v=XqPQnSSAg68 - 4: https://gist.github.com/Iliannnn/f4985563833e2538b1b96a8cb89d72bb - 5: https://github.com/Tolga1452/discord.js-v14-template/releases - 6: https://www.youtube.com/watch?v=et_bzG3WJDg - 7: https://discordjs.guide/creating-your-bot/event-handling - 8: https://support.glitch.com/t/going-to-need-another-node-update-discord-js-node-16-6-0-requirement/45235 - 9: https://www.youtube.com/watch?v=y_MD8A4qvjE - 10: https://www.youtube.com/watch?v=YkpBaeM_WSM
LGTM! Event constant updated correctly.
The code now directly imports Events from discord.js and correctly uses the PascalCase constant (GuildMemberAdd) as recommended in discord.js v14. The web query confirms that these changes align with the new event naming conventions.
src/eventHandlers/NotifyVulgarName.js (1)
1-1: LGTM! Event constant updated correctly.The changes align with discord.js v14's best practices:
- Direct import of Events from discord.js
- Updated event constant to camelCase (GuildMemberAdd)
Also applies to: 13-13
src/eventHandlers/NotifyOwnerJoin.js (1)
1-1: LGTM! Event constant updated correctly.The changes align with discord.js v14's best practices:
- Direct import of Events from discord.js
- Updated event constant to camelCase (GuildCreate)
Also applies to: 15-15
src/eventHandlers/BulkMessageDeleteHandle.js (1)
1-1:⚠️ Potential issueCritical: Incorrect event constant for bulk message deletion.
The handler is designed for bulk message deletion but is using the wrong event constant.
Events.MessageDeleteis for single message deletion, while this handler expects a collection of messages.Apply this diff to fix the event constant:
- super(bot, 'handlers.logMessageDeleteBulk', Events.MessageDelete); + super(bot, 'handlers.logMessageDeleteBulk', Events.MessageBulkDelete);Also applies to: 17-17
src/eventHandlers/LeaveNotify.js (1)
1-1: LGTM! Changes align with discord.js v14 API.The changes correctly update the event constant to use the new camelCase format (
Events.GuildDelete) and import directly from discord.js.Also applies to: 12-12
src/eventHandlers/JoinNotify.js (1)
1-1: LGTM! Changes align with discord.js v14 API.The changes correctly update the event constant to use the new camelCase format (
Events.GuildCreate) and import directly from discord.js.Also applies to: 12-12
src/eventHandlers/MessageDeleteHandle.js (1)
1-1: LGTM! Changes align with discord.js v14 API.The changes correctly update the event constant to use the new camelCase format (
Events.MessageDelete) and import directly from discord.js.Also applies to: 13-13
src/interactions/core/About.js (1)
1-2: LGTM! Changes align with discord.js v14 API.The changes correctly update the ephemeral flag to use the new
MessageFlags.Ephemeralenum instead of the boolean property.Also applies to: 50-50
src/interactions/warframe/WhatsIn.js (1)
1-1: LGTM! Changes align with discord.js v14 API.The updates correctly implement the new modular imports and ApplicationCommandOptionType constants from discord.js v14.
Also applies to: 11-11, 27-27
src/interactions/core/Ping.js (1)
1-1: LGTM! Correctly migrated to new EmbedBuilder API.The changes properly implement the new EmbedBuilder and EmbedType from discord.js v14.
Also applies to: 43-46
src/interactions/warframe/Calculator.js (1)
1-1: LGTM! Properly migrated command option types.The changes correctly implement ApplicationCommandOptionType constants from discord.js v14 for both integer and subcommand options.
Also applies to: 9-9, 15-15, 21-21, 43-43, 48-48, 53-53
src/interactions/custom/CustomCommands.js (1)
1-1: LGTM! Successfully migrated to new permission system and command option types.The changes correctly implement:
- PermissionsBitField for guild management permissions
- ApplicationCommandOptionType for subcommand and string options
Also applies to: 15-15, 19-19, 23-23, 28-28, 35-35, 39-39, 46-46
src/eventHandlers/DynamicVoiceHandler.js (1)
1-1: LGTM! Changes align with discord.js v14 requirements.The updates correctly implement:
- Specific imports from discord.js
- New PermissionsBitField.Flags for permissions
- CamelCase event names (VoiceStateUpdate, ChannelDelete)
Also applies to: 4-4, 81-81, 88-88
src/eventHandlers/Ready.js (1)
1-1: LGTM! Changes align with discord.js v14 requirements.The updates correctly implement:
- Direct import of Events from discord.js
- CamelCase event name (ClientReady)
Also applies to: 25-25
src/bot.js (1)
1-1: Verify completeness of GatewayIntentBits.While the changes to imports, events, and status are correct, please verify if all necessary intents are included. For example, if you're handling message content, you might need
GatewayIntentBits.MessageContent.Also applies to: 8-8, 57-57, 66-70
src/interactions/warframe/Lookup.js (1)
1-1: LGTM! Changes align with discord.js v14 requirements.The updates correctly implement:
- Direct import of ApplicationCommandOptionType
- Proper enum values for command option types (String, Boolean, Subcommand)
Also applies to: 21-21, 27-27, 40-40, 45-45, 50-50, 55-55, 61-61, 66-66
src/interactions/warframe/LFG.js (4)
1-9: LGTM! Import statements have been correctly updated.The changes properly import specific components from discord.js v14 instead of importing the entire Discord object, which is more efficient and follows best practices.
115-165: LGTM! Command option types have been correctly updated.The changes properly update the command option types to use the new
ApplicationCommandOptionTypeenum from discord.js v14, replacing the oldTypesconstants.
207-220: LGTM! Button components have been correctly updated.The changes properly update the button components to use the new builders and styles from discord.js v14:
MessageButton→ButtonBuilderMessageActionRow→ActionRowBuilderMessageButtonStyles→ButtonStyle
235-236: LGTM! Interaction collector configuration has been correctly updated.The changes properly update the interaction collector to use the new interaction and component types from discord.js v14.
src/utilities/Collectors.js (4)
1-10: LGTM! Import statements have been correctly updated.The changes properly import specific components from discord.js v14, which is more efficient and follows best practices.
14-33: LGTM! Navigation components have been correctly updated.The changes properly update the navigation components to use the new builders and styles from discord.js v14:
MessageActionRow→ActionRowBuilderMessageButton→ButtonBuilderMessageButtonStyles→ButtonStyle
35-49: LGTM! Confirmation components have been correctly updated.The changes properly update the confirmation components to use the new builders and styles from discord.js v14.
333-366: LGTM! Embed builder updates have been correctly implemented.The changes properly update the embed creation to use the new
EmbedBuilderclass from discord.js v14, replacing the oldMessageEmbed.src/eventHandlers/InteractionHandler.js (4)
6-6: LGTM! Import statements have been correctly updated.The changes properly import specific components from discord.js v14, which is more efficient and follows best practices.
54-54: LGTM! Event constant has been correctly updated.The change properly updates the event constant from
Events.INTERACTION_CREATEtoEvents.InteractionCreateto match the new camelCase format in discord.js v14.
118-121: LGTM! Permission flags have been correctly updated.The changes properly update the permission flags to use
PermissionsBitField.Flagsfrom discord.js v14, replacing the oldPermissions.FLAGS.
140-177: LGTM! Command option types have been correctly updated.The changes properly update the command option types to use
ApplicationCommandOptionTypefrom discord.js v14, replacing the old string literals ('ROLE' and 'USER').src/interactions/warframe/Worldstate.js (3)
1-1: LGTM! Import statements have been correctly updated.The changes properly import specific components from discord.js v14, which is more efficient and follows best practices.
68-165: LGTM! Command option types have been correctly updated.The changes properly update the command option types to use
ApplicationCommandOptionTypefrom discord.js v14, replacing the oldTypesconstants.
333-366: LGTM! Embed builder updates have been correctly implemented.The changes properly update the embed creation to use the new
EmbedBuilderclass from discord.js v14, replacing the oldMessageEmbed.🧰 Tools
🪛 Biome (1.9.4)
[error] 352-354: This case is falling through to the next case.
Add a
breakorreturnstatement to the end of this case to prevent fallthrough.(lint/suspicious/noFallthroughSwitchClause)
package.json (1)
54-54: Verify compatibility with discord.js v14.The upgrade from discord.js v13 to v14 is a major version change that introduces breaking changes. Please ensure:
- All breaking changes are addressed across the codebase.
- The Node.js version requirement (>=16.6.2) meets discord.js v14's requirements.
src/interactions/channels/Rooms.js (3)
1-1: LGTM! Import optimization.The import statement has been correctly updated to use specific imports from discord.js v14, which is more efficient than importing the entire module.
31-32: LGTM! Permission flags correctly updated.All permission flags have been properly updated to use
PermissionsBitField.Flagsinstead of the deprecatedPermissions.FLAGS, maintaining appropriate permissions for each context.Also applies to: 42-47, 60-68, 75-81, 89-97
226-226: LGTM! Command option types correctly updated.All command option types have been properly updated to use
ApplicationCommandOptionTypeinstead of the deprecatedTypes, maintaining appropriate types for each command option.Also applies to: 230-231, 237-238, 242-243, 247-248, 252-253, 257-258, 264-265, 268-269, 272-273, 276-277, 280-281, 284-285, 288-289, 292-293, 300-301, 304-305, 312-313, 316-317, 324-325, 328-329
src/utilities/CommonFunctions.js (3)
1-1: LGTM! Import optimization.The import statement has been correctly updated to use specific imports from discord.js v14.
483-484: LGTM! Type annotations updated.The type annotations have been correctly updated to use
EmbedBuilderinstead ofMessageEmbed.Also applies to: 562-563, 581-582
533-533: LGTM! Embed creation updated.All instances of embed creation have been properly updated to use
EmbedBuilderinstead ofMessageEmbed.Also applies to: 584-584, 603-603, 674-674, 706-706
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/interactions/tracking/Tracking.js (1)
549-549: Update permission check to use new format.The permission check is using the old format. Update it to use the new
PermissionsBitFieldformat.-if (channel.permissionsFor(interaction.client.user).has('MANAGE_WEBHOOKS')) { +if (channel.permissionsFor(interaction.client.user).has(PermissionsBitField.Flags.ManageWebhooks)) {
🧹 Nitpick comments (1)
src/eventHandlers/NotifyOwnerJoin.js (1)
20-20: Fix typo in JSDoc comment.There's a typo in the comment: "teh" should be "the".
- * add the guild to teh Database + * add the guild to the Database
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/eventHandlers/AddGuildToDatabase.js(3 hunks)src/eventHandlers/BulkMessageDeleteHandle.js(3 hunks)src/eventHandlers/DeleteChannel.js(3 hunks)src/eventHandlers/LogMemberBan.js(3 hunks)src/eventHandlers/LogMemberRemove.js(3 hunks)src/eventHandlers/LogMemberUnban.js(3 hunks)src/eventHandlers/MessageDeleteHandle.js(2 hunks)src/eventHandlers/NotifyOwnerJoin.js(3 hunks)src/eventHandlers/UpdateGuildStatistics.js(2 hunks)src/interactions/channels/Rooms.js(11 hunks)src/interactions/channels/Templates.js(2 hunks)src/interactions/tracking/Tracking.js(12 hunks)src/utilities/Webhook.js(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
- src/eventHandlers/AddGuildToDatabase.js
- src/eventHandlers/LogMemberRemove.js
- src/eventHandlers/LogMemberUnban.js
- src/eventHandlers/BulkMessageDeleteHandle.js
- src/eventHandlers/UpdateGuildStatistics.js
- src/utilities/Webhook.js
- src/eventHandlers/LogMemberBan.js
- src/interactions/channels/Rooms.js
🔇 Additional comments (22)
src/eventHandlers/NotifyOwnerJoin.js (3)
1-1: LGTM! Import statement updated correctly.The change to import
Eventsspecifically from 'discord.js' aligns with v14's modular import approach.
15-15: LGTM! Event constant updated to v14 format.The event constant has been correctly updated from
GUILD_CREATEtoEvents.GuildCreateto match discord.js v14's camelCase event naming convention.
31-31: LGTM! Guild owner access updated correctly.The changes correctly implement discord.js v14's requirement to fetch the guild owner asynchronously using
guild.fetchOwner()instead of accessing the owner property directly.Also applies to: 39-39, 45-45
src/eventHandlers/DeleteChannel.js (3)
1-1: LGTM! Import statement updated correctly for discord.js v14.The change from importing the entire Discord object to specific imports (
ChannelType,Events) follows the recommended modular approach in discord.js v14.
14-14: LGTM! Event constant updated to follow v14 naming convention.The event constant has been correctly updated from
Events.CHANNEL_DELETEtoEvents.ChannelDeletefollowing discord.js v14's camelCase naming convention.
24-24: LGTM! Channel type check improved using ChannelType enum.The channel type comparison has been updated to use the
ChannelType.GuildVoiceenum instead of a string literal, improving type safety and maintainability.src/eventHandlers/MessageDeleteHandle.js (3)
1-1: LGTM! Import statement updated correctly for discord.js v14.The change from importing the entire Discord object to specific imports (
ChannelType,Events) follows the recommended modular approach in discord.js v14.
13-13: LGTM! Event constant updated to follow v14 naming convention.The event constant has been correctly updated from
Events.MESSAGE_DELETEtoEvents.MessageDeletefollowing discord.js v14's camelCase naming convention.
30-30: LGTM! Channel type check improved using ChannelType enum.The channel type comparison has been updated to use the
ChannelType.GuildTextenum instead of a string literal, improving type safety and maintainability.src/interactions/channels/Templates.js (6)
1-1: LGTM! Correct modular imports for discord.js v14.The change properly imports specific components instead of the entire Discord namespace, following discord.js v14's modular approach.
10-10: LGTM! Correct ApplicationCommandOptionType usage.The change properly uses the new ApplicationCommandOptionType.Channel enum from discord.js v14.
18-18: LGTM! Correct PermissionsBitField usage.The change properly uses the new PermissionsBitField.Flags.ManageGuild enum from discord.js v14.
22-22: LGTM! Consistent ApplicationCommandOptionType.Subcommand usage.The changes properly use the new ApplicationCommandOptionType.Subcommand enum consistently across all subcommands.
Also applies to: 27-27, 32-32, 36-36, 48-48
41-41: LGTM! Correct ApplicationCommandOptionType.String usage.The change properly uses the new ApplicationCommandOptionType.String enum from discord.js v14.
59-59: LGTM! Correct ChannelType enum usage.The change properly uses the new ChannelType.GuildVoice enum instead of the string literal.
src/interactions/tracking/Tracking.js (7)
1-12: LGTM! Clean import restructuring.The imports have been correctly updated to use specific components from discord.js v14, which is a recommended practice for better tree-shaking and bundle optimization.
43-43: LGTM! Permission flag updated correctly.The permission flag has been properly updated from
Permissions.FLAGS.MANAGE_GUILDtoPermissionsBitField.Flags.ManageGuildas per Discord.js v14.
47-47: LGTM! Command option types updated correctly.All command option types have been properly updated to use the new
ApplicationCommandOptionTypeenum from Discord.js v14:
SUB_COMMAND→SubcommandCHANNEL→ChannelSTRING→StringBOOLEAN→BooleanAlso applies to: 51-51, 55-55, 65-65, 69-69, 73-73, 77-77, 81-81, 85-85
208-294: LGTM! Component builders updated correctly.The component builders have been properly updated to use the new builder classes and button styles from Discord.js v14:
MessageActionRow→ActionRowBuilderMessageButton→ButtonBuilderMessageSelectMenu→StringSelectMenuBuilderMessageButtonStyles→ButtonStyle
528-530: LGTM! Utility methods updated correctly.The utility methods have been properly updated to use the new
Utilsclass from Discord.js v14:
Discord.Util.escapeMarkdown→Utils.escapeMarkdownDiscord.Util.removeMentions→Utils.removeMentions
100-100: Verify channel type comparison.The channel type comparison has been updated, but let's verify that
ChannelType.GuildTextis the correct constant to use.✅ Verification successful
🌐 Web query:
What are the available channel types in Discord.js v14?💡 Result:
Discord.js v14 supports multiple channel types through its type system, which are essential for organizing server spaces and handling different communication formats. Here's a breakdown of available channel types: ## Channel Types 1. **CategoryChannel** Used to group text/voice channels under collapsible sections with synchronized permissions[1][4]. 2. **TextChannel** Standard text-based channels for messages and file sharing[2][4]. 3. **VoiceChannel** Designed for voice communication and screen sharing[1][5]. 4. **NewsChannel** Specialized channels for broadcasting announcements cross-postable to follower servers[4][6]. 5. **ForumChannel** Structured channels for organized discussions using threads/posts[3][10]. 6. **StageChannel** Dedicated to live audio events with speakers and listeners[4]. 7. **MediaChannel** Focused on media sharing (introduced in later Discord updates)[4]. 8. **Thread Channels** (`AnyThreadChannel`) Temporary sub-channels under text/forum channels for focused discussions[2][7]. 9. **DM Channels** (`DMChannel`, `PartialDMChannel`, `PartialGroupDMChannel`) Private messaging channels between users or small groups[4][9]. ## Key Features - Categories (`CategoryChannel`) enable permission synchronization across nested channels[1][9]. - Forum channels (`ForumChannel`) support tags and structured posts[10]. - Threads inherit properties from parent channels and auto-archive after inactivity[2][7]. - Type checking can be done using `channel.type === ChannelType.GuildText` comparisons[4][6]. This structure allows granular control over permissions, content types, and organizational hierarchies in Discord servers[1][4][9]. Citations: - 1: https://www.theyurig.com/blog/how-create-categories-discord-v14 - 2: https://www.theyurig.com/blog/how-create-text-channels-discord-v14 - 3: https://discordjs.guide/popular-topics/faq - 4: https://discord.js.org/docs/packages/discord.js/14.14.1/Channel:TypeAlias - 5: https://www.youtube.com/watch?v=0AOpNy_6EjU - 6: https://discord.js.org/docs/packages/discord.js/14.14.1/Message:Class - 7: https://gist.github.com/Iliannnn/f4985563833e2538b1b96a8cb89d72bb - 8: https://discord.js.org/docs/packages/discord.js/14.14.0/GuildChannelManager:Class - 9: https://discord.js.org/docs/packages/discord.js/14.14.0/CategoryChannel:Class - 10: https://discord.js.org/docs/packages/discord.js/14.14.1/ForumChannel:Class
Channel Type Verification
The use of ChannelType.GuildText is correct for checking that the channel is indeed a guild text channel as per Discord.js v14 documentation. No changes are needed in this comparison.
306-308: Verify interaction collector configuration.The interaction collector configuration has been updated, but let's verify the correct constants for
interactionTypeandcomponentType.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/interactions/tracking/Tracking.js (1)
1-622: Consider enhancing error handling and type safety.While the migration to discord.js v14 is complete and correct, consider these improvements:
- Add type annotations for interaction parameters in event handlers
- Use more specific error types in catch blocks
- Consider implementing rate limiting for webhook operations
🧰 Tools
🪛 Biome (1.9.4)
[error] 378-378: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
[error] 536-536: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/interactions/tracking/Tracking.js(13 hunks)
🔇 Additional comments (5)
src/interactions/tracking/Tracking.js (5)
1-12: LGTM! Import statements and command definitions are correctly updated.The changes properly implement discord.js v14's modular imports and new constants for permissions and command options.
Also applies to: 43-43, 47-47, 51-51, 55-55, 65-65, 69-69, 73-73, 77-77, 81-81, 85-85
100-100: LGTM! UI components are correctly migrated to use builders.The changes properly implement:
- Channel type checks using the new
ChannelTypeenum- Component creation using the new builder pattern (
ActionRowBuilder,ButtonBuilder,StringSelectMenuBuilder)- Button styles using the new
ButtonStyleenumAlso applies to: 208-224, 227-238, 241-252, 255-266, 268-297
306-307: LGTM! Interaction collectors and handlers are properly updated.The changes correctly implement:
- New interaction types for collectors
- New component types for button and select menu interactions
Also applies to: 361-362, 382-393, 403-414
528-530: LGTM! Utils methods are properly used.The changes correctly use the new
Utilsmethods for escaping markdown and removing mentions.
549-549: LGTM! Permission checks are properly updated.The changes correctly use
PermissionsBitField.Flagsfor permission checks.
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/interactions/tracking/Tracking.js (1)
305-311: Fix interaction collector configuration.The
interactionTypevalue appears incorrect.interaction.MESSAGE_COMPONENTis not a valid property.const groupCollector = new InteractionCollector(interaction.client, { - interactionType: interaction.MESSAGE_COMPONENT, + interactionType: InteractionType.MessageComponent, componentType: ComponentType.StringSelect, message, guild: interaction.guild, channel: interaction.channel, });
🧹 Nitpick comments (4)
src/interactions/tracking/Tracking.js (3)
99-101: Consider additional channel permission validation.While the channel type check is correct, consider also validating that the bot has necessary permissions (VIEW_CHANNEL, SEND_MESSAGES) in the channel before proceeding.
if (options?.getChannel('channel').type !== ChannelType.GuildText) { return interaction.editReply({ ephemeral: ctx.ephemerate, content: `:warning: ${options.getChannel('channel')} is not a text channel. :warning:`, }); } +const permissions = options.getChannel('channel').permissionsFor(interaction.client.user); +if (!permissions.has([PermissionsBitField.Flags.ViewChannel, PermissionsBitField.Flags.SendMessages])) { + return interaction.editReply({ + ephemeral: ctx.ephemerate, + content: `:warning: Missing required permissions in ${options.getChannel('channel')} :warning:`, + }); +}
528-530: Consider wrapping Utils calls in try-catch.While the Utils methods are correctly used, they could throw errors if the input is malformed.
-const pingsString = ctx.i18n`Adding \`${Utils.escapeMarkdown( - Utils.removeMentions(prepend) -)}\` for ${add?.events?.length || 0} events, ${add?.items?.length || 0} items`; +let sanitizedPrepend; +try { + sanitizedPrepend = Utils.escapeMarkdown(Utils.removeMentions(prepend)); +} catch (error) { + ctx.logger.error('Failed to sanitize prepend:', error); + sanitizedPrepend = '[invalid content]'; +} +const pingsString = ctx.i18n`Adding \`${sanitizedPrepend}\` for ${add?.events?.length || 0} events, ${add?.items?.length || 0} items`;
580-584: Add timeout handling for webhook creation.Consider adding a timeout for the webhook creation operation to prevent hanging.
+const WEBHOOK_TIMEOUT = 5000; // 5 seconds try { - webhook = await channel.createWebhook({ - name: ctx.settings.defaults.username, - avatar: ctx.settings.defaults.avatar, - reason: 'Automated Webhook setup for Notifications', - }); + const createWebhookPromise = channel.createWebhook({ + name: ctx.settings.defaults.username, + avatar: ctx.settings.defaults.avatar, + reason: 'Automated Webhook setup for Notifications', + }); + webhook = await Promise.race([ + createWebhookPromise, + new Promise((_, reject) => + setTimeout(() => reject(new Error('Webhook creation timed out')), WEBHOOK_TIMEOUT) + ), + ]); } catch (e) { ctx.logger.error(e); await interaction.followUp(`${emojify('red_tick')} Cannot set up webhooks: failed to make new.`); }src/interactions/core/su.js (1)
16-16: Consider removing redundant permission.Since the command is already restricted with
ownerOnly: true, thedefaultMemberPermissionssetting is redundant and can be safely removed.- defaultMemberPermissions: PermissionsBitField.Flags.Administrator,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/interactions/core/su.js(5 hunks)src/interactions/tracking/Tracking.js(14 hunks)src/utilities/Webhook.js(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/utilities/Webhook.js
🔇 Additional comments (4)
src/interactions/tracking/Tracking.js (1)
1-12: LGTM! Clean modular imports.The granular imports from discord.js align with v14's modular approach, improving tree-shaking capabilities.
src/interactions/core/su.js (3)
1-1: LGTM! Improved imports.The change to specific imports from discord.js follows best practices and improves code maintainability.
21-21: LGTM! Correct command option type updates.The command option types have been correctly updated to use the new ApplicationCommandOptionType enum from discord.js v14.
Also applies to: 26-26, 31-31, 44-44, 57-57, 70-70, 35-35, 48-48, 61-61, 79-79
127-127: Verify ServerInfoEmbed compatibility with EmbedBuilder.The change from MessageEmbed to EmbedBuilder is correct, but ensure that the ServerInfoEmbed class has been updated to work with EmbedBuilder.
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Check if ServerInfoEmbed has been updated for EmbedBuilder compatibility # Search for MessageEmbed usage in ServerInfoEmbed rg -A 5 "MessageEmbed" "src/embeds/ServerInfoEmbed.js" # Search for EmbedBuilder usage in ServerInfoEmbed rg -A 5 "EmbedBuilder" "src/embeds/ServerInfoEmbed.js"Length of output: 105
Let's take a closer look at the contents of the ServerInfoEmbed file to verify its compatibility with EmbedBuilder. We'll print the file content to inspect if it imports and uses EmbedBuilder appropriately.
🏁 Script executed:
#!/bin/bash # Display the content of the ServerInfoEmbed file for manual inspection. cat src/embeds/ServerInfoEmbed.jsLength of output: 2215
Let's inspect the BaseEmbed file to see if it's updated for EmbedBuilder compatibility. That will help us ensure that ServerInfoEmbed (which extends BaseEmbed) is using the updated EmbedBuilder correctly.
🏁 Script executed:
#!/bin/bash # Display the content of the BaseEmbed file for manual inspection. cat src/embeds/BaseEmbed.jsLength of output: 642
ServerInfoEmbed is compatible with EmbedBuilder.
Both ServerInfoEmbed and its parent class BaseEmbed correctly use EmbedBuilder from discord.js. BaseEmbed imports EmbedBuilder and initializes the embed with default values, and ServerInfoEmbed extends BaseEmbed while setting its properties appropriately. No outdated MessageEmbed usage is found.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/interactions/core/Settings.js (2)
542-542: Replacethiswith class name in static context.Using
thisin a static context can be confusing. Use the class name instead for better clarity.Apply this diff to fix the issue:
- `${perms.has(PermissionsBitField.Flags.ManageRoles) ? this.#check : this.#xmark} Permission Present` + `${perms.has(PermissionsBitField.Flags.ManageRoles) ? Settings.#check : Settings.#xmark} Permission Present` - perms.has(PermissionsBitField.Flags.ManageWebhooks) ? `${this.#check} Can` : `${this.#xmark} Cannot` + perms.has(PermissionsBitField.Flags.ManageWebhooks) ? `${Settings.#check} Can` : `${Settings.#xmark} Cannot`Also applies to: 553-553
🧰 Tools
🪛 Biome (1.9.4)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
227-227: Update JSDoc return type.The JSDoc comment still references the old
Discord.MessageEmbedtype.Apply this diff to fix the issue:
- * @returns {Promise<Array<Discord.MessageEmbed>>} + * @returns {Promise<Array<EmbedBuilder>>}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/interactions/core/Settings.js(12 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
src/interactions/core/Settings.js
[error] 525-526: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 553-553: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 553-553: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
🔇 Additional comments (4)
src/interactions/core/Settings.js (4)
1-1: LGTM! Import statement updated correctly.The import statement has been properly updated to use specific imports from discord.js v14, which is more efficient than importing the entire Discord object.
26-27: LGTM! Command option types updated correctly.All command option types have been properly updated to use the new
ApplicationCommandOptionTypeenum from discord.js v14.Also applies to: 48-49, 59-60, 70-71, 81-82, 92-93, 105-106, 117-118, 122-123, 135-136, 147-148, 161-162, 173-174, 184-185
405-405: LGTM! Permission flags updated correctly.The permission flags have been properly updated to use the new
PermissionsBitField.Flagsfrom discord.js v14.
230-230: LGTM! MessageEmbed replaced with EmbedBuilder.All instances of
MessageEmbedhave been correctly replaced withEmbedBuilderfrom discord.js v14.Also applies to: 381-381, 525-525
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
src/interactions/channels/Templates.js (1)
115-118: Update reply to use flags instead of ephemeral.For consistency with other changes in the file, update this reply to use flags instead of ephemeral.
Apply this diff:
- ephemeral: ctx.ephemerate, + flags: ctx.flags,
🧹 Nitpick comments (2)
src/interactions/core/Settings.js (1)
542-542: Replacethiswith class name in static context.Using
thisin a static context can be confusing. Use the class name instead.Apply this diff to fix the issue:
- `${perms.has(PermissionsBitField.Flags.ManageRoles) ? this.#check : this.#xmark} Permission Present` + `${perms.has(PermissionsBitField.Flags.ManageRoles) ? Settings.#check : Settings.#xmark} Permission Present`🧰 Tools
🪛 Biome (1.9.4)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
src/interactions/tracking/Tracking.js (1)
580-584: Consider adding specific error handling for webhook creation.While the code correctly uses the new options object pattern for webhook creation, consider adding specific error handling for common webhook creation failures (e.g., rate limits, permission issues) to provide more informative error messages.
try { webhook = await channel.createWebhook({ name: ctx.settings.defaults.username, avatar: ctx.settings.defaults.avatar, reason: 'Automated Webhook setup for Notifications', }); } catch (e) { ctx.logger.error(e); + if (e.code === 30007) { + await interaction.followUp(`${emojify('red_tick')} Cannot set up webhooks: webhook limit reached for this channel.`); + } else if (e.code === 50013) { + await interaction.followUp(`${emojify('red_tick')} Cannot set up webhooks: missing required permissions.`); + } else { await interaction.followUp(`${emojify('red_tick')} Cannot set up webhooks: failed to make new.`); + } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (19)
src/bot.js(4 hunks)src/eventHandlers/InteractionHandler.js(8 hunks)src/interactions/channels/Rooms.js(19 hunks)src/interactions/channels/Templates.js(3 hunks)src/interactions/core/Ping.js(4 hunks)src/interactions/core/Settings.js(13 hunks)src/interactions/core/su.js(6 hunks)src/interactions/custom/CustomCommands.js(3 hunks)src/interactions/fun/Hug.js(1 hunks)src/interactions/fun/Joke.js(2 hunks)src/interactions/tracking/Tracking.js(16 hunks)src/interactions/warframe/Builds.js(10 hunks)src/interactions/warframe/Calculator.js(3 hunks)src/interactions/warframe/LFG.js(6 hunks)src/interactions/warframe/Lookup.js(4 hunks)src/interactions/warframe/PriceCheck.js(3 hunks)src/interactions/warframe/WhatsIn.js(3 hunks)src/interactions/warframe/WhereIs.js(3 hunks)src/utilities/Webhook.js(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
- src/interactions/core/Ping.js
- src/interactions/warframe/WhatsIn.js
- src/interactions/fun/Joke.js
- src/utilities/Webhook.js
- src/interactions/warframe/Lookup.js
- src/eventHandlers/InteractionHandler.js
- src/interactions/warframe/PriceCheck.js
- src/interactions/warframe/Calculator.js
- src/interactions/core/su.js
🧰 Additional context used
🪛 Biome (1.9.4)
src/interactions/warframe/Builds.js
[error] 440-458: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
[error] 524-530: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
src/interactions/core/Settings.js
[error] 525-526: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 542-542: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 553-553: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 553-553: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
🔇 Additional comments (22)
src/interactions/fun/Hug.js (1)
12-12: Verify the flags usage aligns with discord.js v14 documentation.The change from
ephemeraltoflagsaligns with the discord.js v14 upgrade. However, let's verify this is implemented correctly.✅ Verification successful
🌐 Web query:
How to set ephemeral messages in discord.js v14?💡 Result:
To set ephemeral messages in Discord.js v14, use either direct flags in response methods or leverage Discord's API constraints for hidden interactions. Here's how to implement them effectively: ## Initial Ephemeral Replies Use `ephemeral: true` in reply options: ```javascript // Basic ephemeral reply await interaction.reply({ content: 'Secret message', ephemeral: true }); // With embeds/components const embed = new EmbedBuilder().setDescription('Ephemeral embed'); await interaction.reply({ embeds: [embed], components: [actionRow], ephemeral: true }); ``` [4][7][9] ## Deferred Ephemeral Responses When using deferred replies: ```javascript // Defer with ephemeral flag await interaction.deferReply({ ephemeral: true }); // Later edit/update (retains ephemeral) await interaction.editReply('Updated hidden message'); ``` [1][4][9] ## Ephemeral Follow-ups For subsequent messages after initial response: ```javascript // First reply (non-ephemeral) await interaction.reply('Public message'); // Ephemeral follow-up await interaction.followUp({ content: 'Hidden follow-up', flags: MessageFlags.Ephemeral // Alternative syntax }); ``` [9][5] ## Key Limitations - **Deferral Lock**: Once deferred with `ephemeral`, all subsequent responses inherit this state[1] - **Message Management**: - Ephemeral messages can't be fetched via `messages.fetch()`[2][3] - Use interaction methods (`editReply()`, `deleteReply()`) for modifications[4][8] - **15-Minute Window**: Interaction tokens expire 15 minutes after initial response[9] For components in ephemeral messages: ```javascript // Button in ephemeral message const button = new ButtonBuilder() .setCustomId('secret-btn') .setLabel('Ephemeral Button'); await interaction.reply({ components: [new ActionRowBuilder().addComponents(button)], ephemeral: true }); ``` [2][7] When combining deferral and follow-ups: ```javascript // Defer publicly but send private follow-up await interaction.deferReply({ ephemeral: false }); await interaction.followUp({ content: 'Hidden after public defer', ephemeral: true }); // This will appear as separate message ``` [1][6] Remember that ephemerality can't be changed after initial response - plan your interaction flow accordingly[1][8]. Use `MessageFlags.Ephemeral` (value 64) for direct flag manipulation when needed[5]. Citations: - 1: https://github.com/discordjs/discord.js/issues/5702 - 2: https://www.answeroverflow.com/m/1155986363150258217 - 3: https://www.answeroverflow.com/m/1133851560879857674 - 4: https://discord.js.org/docs/packages/discord.js/14.14.0/CommandInteraction:Class - 5: https://discord.js.org/docs/packages/discord.js/14.17.3/MessageFlags:Enum - 6: https://www.youtube.com/watch?v=jntUHXiFB8g - 7: https://discord.js.org/docs/packages/discord.js/14.14.1/MessageComponentInteraction:Class - 8: https://github.com/discord/discord-api-docs/issues/6007 - 9: https://discordjs.guide/slash-commands/response-methods - 10: https://support-apps.discord.com/hc/en-us/articles/26501839512855-Ephemeral-Messages-FAQ
Flags usage in Hug.js aligns with discord.js v14 expectations.
The change from using the boolean ephemeral option to passing flags (presumably set to MessageFlags.Ephemeral when needed) is consistent with the standardized approach across the codebase. As verified by the query results, while initial ephemeral replies typically use the ephemeral boolean, using flags is acceptable when the value is properly computed (as with ctx.flags) to represent ephemeral behavior.
• Confirm that ctx.flags holds the appropriate flags value (e.g., MessageFlags.Ephemeral) when an ephemeral reply is intended.
• The updated implementation reflects the intended upgrade for discord.js v14.src/bot.js (3)
1-1: LGTM! Clean import restructuring.The direct imports from discord.js improve code clarity and follow the v14 module structure.
64-68: LGTM! Intents correctly updated.The intents have been properly updated to use GatewayIntentBits enum.
144-172: LGTM! Event names correctly updated.All event names have been properly updated to use the new camelCase format from the Events enum.
src/interactions/custom/CustomCommands.js (2)
1-1: LGTM! Permissions correctly updated.The permissions have been properly updated to use PermissionsBitField.Flags.ManageGuild.
Also applies to: 15-15
19-46: LGTM! Command option types correctly updated.All command option types have been properly updated to use ApplicationCommandOptionType enum.
src/interactions/warframe/WhereIs.js (2)
1-1: LGTM! Embed creation updated.The embed creation has been properly updated to use EmbedBuilder.
Also applies to: 95-95
14-14: LGTM! Command option type correctly updated.The command option type has been properly updated to use ApplicationCommandOptionType.String.
src/interactions/channels/Templates.js (1)
1-1: LGTM! Channel type check updated.The channel type check has been properly updated to use ChannelType.GuildVoice.
Also applies to: 59-59
src/interactions/warframe/LFG.js (4)
1-11: LGTM!The imports are correctly updated to use specific imports from discord.js v14 instead of importing the entire module.
202-204: LGTM!The error handling for channel resolution is correctly updated to use
flagsinstead ofephemeral.
206-223: LGTM!The button components are correctly updated to use the new builders and styles from discord.js v14:
MessageActionRow→ActionRowBuilderMessageButton→ButtonBuilderMessageButtonStyles→ButtonStyle
234-237: LGTM!The interaction collector is correctly updated to use the new types from discord.js v14:
InteractionTypes.MESSAGE_COMPONENT→InteractionType.MessageComponentMessageComponentTypes.BUTTON→ComponentType.Buttonsrc/interactions/core/Settings.js (2)
1-1: LGTM!The imports are correctly updated to use specific imports from discord.js v14 instead of importing the entire module.
525-526:⚠️ Potential issueFix variable declaration in switch statement.
The variable declaration in the switch statement can be erroneously accessed by other cases. This could lead to unexpected behavior.
Apply this diff to fix the issue:
case 'diag': + { const embed = new EmbedBuilder(); embed.setTitle(`Diagnostics for Shard ${interaction.guild.shardId + 1}/${interaction.client.ws.shards.size}`); + }Likely invalid or redundant comment.
🧰 Tools
🪛 Biome (1.9.4)
[error] 525-526: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
src/interactions/warframe/Builds.js (1)
1-11: LGTM!The imports are correctly updated to use specific imports from discord.js v14 instead of importing the entire module.
src/interactions/channels/Rooms.js (3)
1-1: LGTM!The imports are correctly updated to use specific imports from discord.js v14 instead of importing the entire module.
31-97: LGTM!The permission flags are correctly updated to use
PermissionsBitField.Flagsinstead of the oldPermissions.FLAGS.
141-165: LGTM!The channel types are correctly updated to use
ChannelTypeinstead of the old channel type constants.src/interactions/tracking/Tracking.js (3)
1-12: LGTM! Improved imports for better tree-shaking.The updated imports follow discord.js v14's recommended pattern of importing specific components instead of the entire Discord namespace. This change enables better tree-shaking and potentially reduces bundle size.
43-86: LGTM! Correctly updated permission flags and command option types.The changes properly implement discord.js v14's new permission system using
PermissionsBitFieldand command option types usingApplicationCommandOptionType.
305-311: Verify the interaction collector configuration.The
interactionTypeis usinginteraction.MESSAGE_COMPONENTwhich seems incorrect. According to the discord.js v14 documentation, it should be usingInteractionType.MessageComponentfrom the discord.js package.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/utilities/CommonFunctions.js (1)
599-609: Consider using builder methods instead of direct data manipulation.While the code works, directly manipulating
embed.datais not recommended. Consider using the builder methods provided by discord.js v14 for better maintainability and future compatibility.Apply this diff to use builder methods:
- if (embed.data.fields?.length > fieldLimit) { - const fieldGroups = createGroupedArray(embed.data.fields, fieldLimit); + const fields = embed.data.fields || []; + if (fields.length > fieldLimit) { + const fieldGroups = createGroupedArray(fields, fieldLimit); const embeds = []; fieldGroups.forEach((fields, index) => { const smEmbed = new EmbedBuilder(embedDefaults); embed.setTitle(title); - smEmbed.data.fields = fields; + smEmbed.addFields(fields); if (index === 0) { - smEmbed.setDescription(embed.data.description); + smEmbed.setDescription(embed.description); } embeds.push(smEmbed); });src/interactions/core/Settings.js (2)
26-27: Consider extracting repeated command option types.The ApplicationCommandOptionType is repeated across multiple command definitions. Consider extracting these into constants to improve maintainability.
+ const COMMAND_TYPES = { + SUBCOMMAND: ApplicationCommandOptionType.Subcommand, + BOOLEAN: ApplicationCommandOptionType.Boolean, + CHANNEL: ApplicationCommandOptionType.Channel, + STRING: ApplicationCommandOptionType.String, + }; static #rooms = [ { ...cmds['settings.allow_rooms'], - type: ApplicationCommandOptionType.Subcommand, + type: COMMAND_TYPES.SUBCOMMAND, // ... rest of the code }, // ... other commands ];Also applies to: 44-45, 55-56, 66-67, 77-78, 88-89, 101-102, 113-114, 131-132, 143-144, 157-158, 169-170, 181-182
535-537: Replace 'this' with class name in static methods.Using 'this' in static methods can be confusing. Consider using the class name instead for better clarity.
- `${perms.has(PermissionsBitField.Flags.ManageRoles) ? this.#check : this.#xmark} Permission Present` + `${perms.has(PermissionsBitField.Flags.ManageRoles) ? Settings.#check : Settings.#xmark} Permission Present` - rolePermTokens.push(`${this.#empty} Bot role position: ${interaction.guild.members.me.roles.highest.position}`); + rolePermTokens.push(`${Settings.#empty} Bot role position: ${interaction.guild.members.me.roles.highest.position}`); `${ - perms.has(PermissionsBitField.Flags.ManageWebhooks) ? `${this.#check} Can` : `${this.#xmark} Cannot` + perms.has(PermissionsBitField.Flags.ManageWebhooks) ? `${Settings.#check} Can` : `${Settings.#xmark} Cannot` } Manage Webhooks`,Also applies to: 546-547
🧰 Tools
🪛 Biome (1.9.4)
[error] 535-535: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
[error] 535-535: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
[error] 537-537: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.(lint/complexity/noThisInStatic)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/interactions/core/Settings.js(14 hunks)src/utilities/CommonFunctions.js(8 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
src/interactions/core/Settings.js
[error] 518-519: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.
The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
[error] 535-535: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 535-535: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 537-537: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 546-546: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
[error] 546-546: Using this in a static context can be confusing.
this refers to the class.
Unsafe fix: Use the class name instead.
(lint/complexity/noThisInStatic)
🔇 Additional comments (5)
src/utilities/CommonFunctions.js (3)
1-1: LGTM! Using specific imports.The change to import specific classes directly from discord.js is aligned with v14's modular import system.
483-483: LGTM! Updated parameter types for discord.js v14.The parameter type changes from MessageEmbed to EmbedBuilder are consistent with discord.js v14's breaking changes.
Also applies to: 562-562
533-536: LGTM! Correctly implemented EmbedBuilder API.The changes properly implement the new EmbedBuilder API, including:
- Using instanceof EmbedBuilder for type checking
- Using the new object-based setter method for footer
Also applies to: 584-584
src/interactions/core/Settings.js (2)
1-1: LGTM! Clean import statement.The specific imports from discord.js follow best practices and align with v14 changes.
518-519: Fix variable declaration in switch statement.The variable declaration in the switch statement can be erroneously accessed by other cases. This could lead to unexpected behavior.
Apply this diff to fix the issue:
case 'diag': + { const embed = new EmbedBuilder(); embed.setTitle(`Diagnostics for Shard ${interaction.guild.shardId + 1}/${interaction.client.ws.shards.size}`); + }🧰 Tools
🪛 Biome (1.9.4)
[error] 518-519: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.The declaration is defined in this switch clause:
Unsafe fix: Wrap the declaration in a block.
(lint/correctness/noSwitchDeclarations)
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/utilities/CommonFunctions.js (1)
533-536: LGTM! Correctly updated to use EmbedBuilder API.The changes properly handle the new EmbedBuilder API in discord.js v14. Consider extracting common embed operations into helper functions to reduce duplication and improve maintainability.
Consider creating helper functions for common embed operations:
+const setEmbedFooter = (embed, text, iconURL) => { + embed.setFooter({ text, iconURL }); +}; + +const setEmbedFields = (embed, fields) => { + embed.setFields(fields.map(field => ({ + ...field, + inline: true + }))); +};Also applies to: 584-584, 599-601, 606-608
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/utilities/CommonFunctions.js(8 hunks)
🔇 Additional comments (1)
src/utilities/CommonFunctions.js (1)
1-1: LGTM! Improved import statement.The change to import specific components instead of the entire module is better for tree-shaking and aligns with discord.js v14 practices.
Summary:
Resolves issue:
resolves #925
Screenshots:
Summary by CodeRabbit
This update refines the bot’s infrastructure and ensures a smoother, more consistent user experience.