Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Optimize ERC6492 workflow #1163

Merged
merged 3 commits into from
Nov 9, 2024
Merged

⚡️ Optimize ERC6492 workflow #1163

merged 3 commits into from
Nov 9, 2024

Conversation

Vectorized
Copy link
Owner

Description

⚡️

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Nov 9, 2024

Gas Snapshot Comparison Report

Generated at commit : 9cb9b41, Compared to commit : 4ad6659

Contract Name Test Name Main Gas PR Gas Diff
SignatureCheckerLibTest testERC6492AllowSideEffectsOnEOA() 39942 39159 -783
testERC6492AllowSideEffectsPostDeploy() 492220 492501 281
testERC6492AllowSideEffectsPreDeploy() 504896 504285 -611
testERC6492OnEOA() 36371 35585 -786
testERC6492PostDeploy() 543683 543831 148
testERC6492PreDeploy() 1369834 1368956 -878
testERC6492WithoutRevertingVerifier() 74959 73558 -1401
testEmptyCalldataHelpers() 3917 3918 1
testSignatureCheckerOnEOAWithInvalidSignature() 21361 21362 1
testSignatureCheckerOnEOAWithInvalidSigner() 30861 30862 1
testSignatureCheckerOnEOAWithMatchingSignerAndSignature() 17759 17760 1
testSignatureCheckerOnEOAWithWrongSignedMessageHash() 21385 21386 1
testSignatureCheckerOnMaliciousWallet() 31952 31953 1
testSignatureCheckerOnWalletWithInvalidSignature() 78991 78992 1
testSignatureCheckerOnWalletWithInvalidSigner() 26094 26095 1
testSignatureCheckerOnWalletWithMatchingSignerAndSignature() 66072 66073 1
testSignatureCheckerOnWalletWithWrongSignedMessageHash() 66126 66127 1
test__codesize() 18619 18640 21

@Vectorized Vectorized merged commit 0bc9737 into main Nov 9, 2024
15 checks passed
@Vectorized Vectorized deleted the opt-6492 branch November 9, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant