Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Paths rather than strings where possible #1040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Paths rather than strings where possible #1040

wants to merge 1 commit into from

Conversation

oscargus
Copy link
Contributor

Avoids quite a bit of conversions back and forth.

Also add some typing to make it easier to remember...

@oscargus oscargus force-pushed the pathlib branch 4 times, most recently from 1bde33f to d2865ed Compare July 11, 2024 14:58
@oscargus
Copy link
Contributor Author

oscargus commented Jul 11, 2024 •
edited
Loading

The !s specifier is not required (unless a special case where one would like to override specifiers in the string). There are 200 or so remaining locations, but I changed where I saw them.

The cwd argument can be a Path. A bit unsure about the other arguments though, so still use strings there.

@oscargus oscargus marked this pull request as ready for review July 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oscargus