add from amount support #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 28, 2024
src/PositionManager.sol
Outdated
| PoolKey calldata poolKey, | ||
| int24 tickLower, | ||
| int24 tickUpper, | ||
| uint128 amount0, |
There was a problem hiding this comment.
now that i think about it im wondering if theres ever a time that amount0 and amount1 would ever not just be OPEN_DELTA? I dont really see a usecase aside from that?
so could even potentially just remove those parameters and just always look up open deltas and then add that much liquidity?
hensha256
reviewed
Nov 6, 2024
kmbarry1
reviewed
Nov 10, 2024
|
|
||
| uint256 constant SETTLE_TAKE_PAIR = 0x18; | ||
| uint256 constant CLOSE_CURRENCY = 0x19; | ||
| uint256 constant CLEAR_OR_TAKE = 0x20; |
There was a problem hiding this comment.
Just curious, why the aversion to hex digits abcdef? 0x18 + 0x2 = 0x1a
There was a problem hiding this comment.
Just a mistake I think
HickupHH3
reviewed
Nov 11, 2024
| import {SafeCast} from "@uniswap/v4-core/src/libraries/SafeCast.sol"; | ||
|
|
||
| /// @notice Provides functions for computing liquidity amounts from token amounts and prices | ||
| library LiquidityAmounts { |
There was a problem hiding this comment.
diffed with v3 lib, can wrap the functions in unchecked blocks; subtractions guaranteed to not overflow
HickupHH3
reviewed
Nov 11, 2024
| _getFullCredit(poolKey.currency1) | ||
| ); | ||
|
|
||
| _mint(poolKey, tickLower, tickUpper, uint256(liquidity), amount0Max, amount1Max, owner, hookData); |
There was a problem hiding this comment.
redundant uint256 casting
Suggested change
| _mint(poolKey, tickLower, tickUpper, uint256(liquidity), amount0Max, amount1Max, owner, hookData); | |
| _mint(poolKey, tickLower, tickUpper, liquidity, amount0Max, amount1Max, owner, hookData); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes