➕ Add global usage of PoolIdLibrary for PoolKey struct
#819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GianfrancoBazzani
changed the title
PoolIdLibrary for PoolKey struct
hensha256
requested changes
Aug 13, 2024
GianfrancoBazzani
force-pushed
the
main
branch
3 times, most recently
from
cf47981
to
6939acc
Compare
GianfrancoBazzani
force-pushed
the
main
branch
from
6939acc
to
8289b48
Compare
❌ Get rid of all `using PoolIdLibrary for PoolKey;` directives ❌ Get rid of all unused `PoolIdLibrary` imports ❌ of unnecessary `using CurrencyLibrary for Currency;` directives
|
hensha256
previously approved these changes
Aug 29, 2024
|
Hi! Sorry you have some merge conflicts form another PR we merged. Please can you fix those? |
GianfrancoBazzani
force-pushed
the
main
branch
2 times, most recently
from
8b11daf
to
0137bd1
Compare
|
Done! |
hensha256
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition will allow the usage of the method
PoolKey.toId()without require to import thePoolIdLibraryand use theusing PoolIdLibrary for PoolKeydirective.