Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct clock skew on AWS global config #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhongeric
Copy link
Collaborator

@zhongeric zhongeric commented Aug 19, 2024

Per the docs, correctClockSkew is automatically applied in aws cdk v3 in later: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/migrating/notable-changes/

I think we are on V2 so we have to manually set this?

@zhongeric zhongeric changed the title fixcorrect clock skew on AWS global config fix: correct clock skew on AWS global config Aug 19, 2024
@ConjunctiveNormalForm
Copy link
Member

ConjunctiveNormalForm commented Aug 19, 2024

We are using v3 sdk for s3:

import { GetObjectCommand, S3Client } from '@aws-sdk/client-s3';

@aws-sdk/<individual-component> is v3, import <...> from 'aws-sdk'; is v2

I think the only thing that's using v2 still is cw-log-firehose-processor, which is a lambda that transforms logs to firehose event format

Copy link
Member

@ConjunctiveNormalForm ConjunctiveNormalForm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to give this a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants