Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethanrushh/brotli fix #663

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ethanrushh
Copy link

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix, dependency update

  • What is the current behavior? (You can also link to an open issue here)

Brotli.js does not work in browsers

  • What is the new behavior (if this is a feature change)?

Brotli.js has been replaced with brotli-wasm

  • Other information:

Fixes #662

I am not fully sure about which brotli params are required to accurately get the length we're looking for here, so I will need someone to edit if possible to ensure what we're looking for is what we get. Tested on my end, seems to work perfectly through node, though haven't tested in a browser yet.

@ethanrushh ethanrushh requested a review from a team as a code owner August 17, 2024 10:37
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem 0 3.25 MB pimterry

🚮 Removed packages: npm/[email protected]

View full report↗︎

@ethanrushh ethanrushh changed the title Ethanrushhh/brotli fix ethanrushh/brotli fix Aug 17, 2024
Copy link

stale bot commented Oct 17, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Oct 17, 2024
@ethanrushh
Copy link
Author

Any thoughts from the devs on this one?

@stale stale bot removed the wontfix This will not be worked on label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package does not work in browser due to Brotli dependency (Arbitrum one/goerli)
1 participant