VPC endpoint to unirpc #881
Conversation
melodylove-uniswap
commented
Oct 19, 2024
•
melodylove-uniswap
commented
- put routing-api behind a vpc
- created a vpc endpoint to connect to unirpc vpc endpoint service in uniswap-backend account
- created route53 to point routing-dev to the vpc endpoint to avoid updating the endpoint on the service side.
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
d9bd8a0
to
5a50abc
Compare
graphite-app
bot
requested review from
xrsv,
cgkol,
jsy1218 and
a team
and removed request for
jsy1218
Graphite Automations"Request reviewers once CI passes on routing-api repo" took an action on this PR • (10/31/24)1 assignee was added and 5 reviewers were added to this PR based on 's automation. |
| @@ -171,6 +244,8 @@ export class RoutingLambdaStack extends cdk.NestedStack { | |||
| runtime: aws_lambda.Runtime.NODEJS_18_X, | |||
| entry: path.join(__dirname, '../../lib/handlers/index.ts'), | |||
| handler: 'quoteHandler', | |||
| vpc: vpc, | |||
There was a problem hiding this comment.
is it possible to set vpc to only caching routing lambda first?
There was a problem hiding this comment.
updated to put both lambda under vpc as we discussed
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
996fb92
to
452fcb6
Compare
| cidrMask: 24, // IP range for private subnet | ||
| }, | ||
| ], | ||
| natGateways: 1, // One NAT Gateway for private subnet internet access |
There was a problem hiding this comment.
not sure if related but good to mention here:
on the unirpc side we started hitting a port connections limit once i started ramping up traffic for routing api
It's weird that routing api lambda didn't hit similar issue, as it is doing similar size of http calls to QN directly.
After further digging, I see that routing api default VPC doesn't have a NAT gateway (and can't see active connections dashboards)?
But with this change we are introducing new VPC with NAT gateway, so trying to understand if that might cause issues due to high amount of traffic.
Anyway we could test the new vpc introduction somehow before fully enabling?
melodylove-uniswap
force-pushed
the
melody-love/vpc-endpoint
branch
from
452fcb6
to
e8bc29a
Compare
