fix: dynamic fee incorrect encoding #40
Open
+82
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hensha256 i did notice, that mixed-quoter lib v4-periphery @ 47e3c30 is 3 weeks ago, and if i were to update v4-periphery import, it would break https://github.com/Uniswap/mixed-quoter/blob/main/src/MixedRouteQuoterV2.sol#L84 |
hensha256
reviewed
Oct 21, 2024
| /// for example, a v4 fee 100% is 1000000, or 000011110100001001000000 | ||
| /// 000011110100001001000000 & 100011111111111111111111 = 000011110100001001000000 | ||
| /// if v4 fee is dynamic, then it's 100000000000000000000000 | ||
| /// 100000000000000000000000 & 100011111111111111111111 = 100000000000000000000000 |
There was a problem hiding this comment.
would love a comment explaining what the 3 0s are for to explain the mask more clearly
hensha256
reviewed
Oct 21, 2024
| uint24 encodedFee = (uint24(protocolVersion) << v4FeeShift) + fee; | ||
| uint8 v3ProtocolVersion = uint8(3); | ||
| uint24 encodedV3Fee = (uint24(v3ProtocolVersion) << v4FeeShift) + fee; | ||
| console.log(encodedV3Fee); |
hensha256
reviewed
Oct 21, 2024
| nonEncodableData[0] = (IMixedRouteQuoterV2.NonEncodableData({hookData: hookData})); | ||
| nonEncodableData[1] = (IMixedRouteQuoterV2.NonEncodableData({hookData: hookData})); | ||
|
|
||
| // bytes memory path = abi.encodePacked(V4_SEPOLIA_OP_ADDRESS, fee,tickSpacing, hooks, V4_SEPOLIA_USDC_ADDRESS); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.