-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run JuliaFormatter on more files, remove trailing whitespace #2374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2374 +/- ##
==========================================
+ Coverage 86.39% 86.45% +0.06%
==========================================
Files 22 22
Lines 1573 1573
==========================================
+ Hits 1359 1360 +1
+ Misses 214 213 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't entirely feel comfortable with model functions being edited to include return statements (they aren't really functions), but that's probably just me.
The two syntaxes, with and without explicit |
Pull Request Test Coverage Report for Build 11497906386Details
💛 - Coveralls |
They are equivalent, yeah. I just think that the rationale for inserting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mhauru and @penelopeysm!
The only actual change is the change in
.JuliaFormatter.toml
. Everything else is a consequence of running autoformatting and auto-whitespace-removal.This will clean-up the diff in #1887 a lot, since the formatter has already been run there.