Offline Digital Euro #157

Robert-ML · 2023-04-24T10:46:05Z

Offline money transfer application with double spent token detection and trust loss for the detected double spender.

Still not fully functional

into adrians

…he Trustchain Superapp to have access to the initialized IPv8 network

…s initialized correctly compared to what I tried to use previously. Solved hashing BUG. The application now shows the promise as a QR code. Possible bug: transition automatically to set amount page, to be investigated.

into adrians

Adrians

into adrians � Conflicts: � offlinemoney/build.gradle � offlinemoney/src/main/java/nl/tudelft/trustchain/offlinemoney/MainActivityOfflineMoney.kt � offlinemoney/src/main/java/nl/tudelft/trustchain/offlinemoney/ui/OfflineMoneyBaseFragment.kt

…ularity_integration

OrestisKan

Seems alright, no major issue was identified but there are some bad practices in the code that should be addressed before the code enters the production android app.

OrestisKan · 2023-04-24T14:40:00Z

offlinedigitaleuro/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/db/UserData.kt

+//    @Query("DELETE FROM userdata_table")
+//    suspend fun deleteUserData()


Delete unused code

OrestisKan · 2023-04-24T14:44:38Z

offlinedigitaleuro/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/src/Wallet.kt

+        internal val privateKey: PrivateKey = defaultCryptoProvider.keyFromPrivateBin(
+            byteArrayOf(
+                76, 105, 98, 78, 97, 67, 76, 83, 75, 58, -29, -114, 126, -47, -39, -5, 22, 89,
+                94, 71, -1, 118, -30, 120, -8, -75, 2, 102, 99, -21, 57, -95, 124, 126, -30, 33,
+                -99, 37, -125, -105, 20, -45, 94, 2, -109, 125, 98, -52, 84, -54, -47, 13, 15, 75,
+                73, 11, -128, 5, -4, -101, 102, -1, -95, 33, -107, -77, -41, 89, 102, 44, 71, 107, 1, 107
+            )
+        )


This seams unsafe, should not be hardcoded in the main codebase

This is only for the demo in order to be able sign generated tokens on any phone. In a real scenario this would not be here and we would use only the publick key to verify the signature. If we remove this, we break the demo functionality of the app. Is it ok to leave it here or how to you sugest to manage the situation?

OrestisKan · 2023-04-24T14:48:03Z

...aleuro/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/ui/PrintDigitalEuroFragment.kt

Variable names in this file and the variable names in nl.tudelft.trustchain.offlinedigitaleuro.databinding.PrintMoneyFragmentBinding are not very explanatory, consider changing them

OrestisKan · 2023-04-24T14:49:05Z

offlinedigitaleuro/build.gradle

+//    kotlinOptions {
+//        jvmTarget = '1.8'
+//    }


delete commented out code

OrestisKan · 2023-04-24T14:49:22Z

offlinedigitaleuro/build.gradle

+//    viewBinding {
+//        enabled = true
+//    }


delete commented out code

OrestisKan · 2023-04-24T14:57:40Z

...c/main/java/nl/tudelft/trustchain/offlinedigitaleuro/ui/transactions/TransactionsFragment.kt

+
+        adapter.registerRenderer(TransactionItemRenderer())
+
+        lifecycleScope.launchWhenResumed {


Is this launched in the background or will it lead to a chokehold?

It is launched in the background and run only once.

OrestisKan · 2023-04-24T14:58:47Z

...o/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/ui/weboftrust/WebOfTrustFragment.kt

+        lifecycleScope.launchWhenResumed {
+            while(isActive) {
+                val items = db.webOfTrustDao().getAllTrustScores()
+                    .map { trustScore: WebOfTrust -> TrustScoreItem(trustScore) }
+                adapter.updateItems(items)
+                adapter.notifyDataSetChanged()
+                delay(1000L)
+            }


Same as the other file,is this launched in the background or may it lead to a chokehold?

It is launched in the background and run only once now after the edit.

OrestisKan · 2023-04-24T15:01:19Z

...gitaleuro/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/utils/TransactionUtility.kt

+
+    // completes a transaction and inserts the tokens in the DB
+    // returns true if the operation succeeded and on failure also returns the message
+    @SuppressLint("SimpleDateFormat")


Not a good practice

OrestisKan · 2023-04-24T15:02:06Z

...gitaleuro/src/main/java/nl/tudelft/trustchain/offlinedigitaleuro/utils/TransactionUtility.kt

+    // completes the transaction by deleting the transferred tokens from the DB and some other stuff
+    // returns true if everything went fine
+    // otherwise returns false and the error message
+    @SuppressLint("SimpleDateFormat")


Not a good practice

OrestisKan · 2023-04-24T15:03:50Z

offlinedigitaleuro/src/test/java/nl/tudelft/trustchain/offlinedigitaleuro/ExampleUnitTest.kt

delete this file

Robert-ML · 2023-05-18T20:30:32Z

Hello @OrestisKan
Can you take another look over our PR to determine if we addressed all your concerns about the best practices?

AdiDumi and others added 30 commits March 8, 2023 11:08

added offline money app

ae3560a

revert to normal

b7ade06

added first basic app hello world

610931b

change color and layour

6b6dec7

styles added

5a5e524

added navigation and fragments to app

f31b0ce

correct get button error

eb7d06a

qr code scanner and add ammount to balance

4e6e9b5

Created QR encoder

79e59b0

Still not fully functional

Merge branch 'adrians' of https://github.com/AdiDumi/trustchain-superapp

fa6b163

into adrians

Got QR encoding to work

2200400

add public key QR

ecbe168

initial push for request payload and promise payload

8a7c668

finished RequestPayload and Promise but not tested

d91cf76

delete sending amount

c37d9a8

Merge remote-tracking branch 'origin/adrians' into adrians

f9cda99

added new page and promise

271b00c

Changed from stand alone application to library and integrated into t…

5e07c79

…he Trustchain Superapp to have access to the initialized IPv8 network

clean code and added named fragments

7df22be

added navigation menu

c72d074

added strings notations for constants

d725b6f

Made a logo for the offline money sub-app trial

23606da

change logic to token based app

111b290

Merge remote-tracking branch 'origin/adrians' into adrians

2ea82b2

Token + Wallet

6095d20

Merge branch 'adrians' of https://github.com/AdiDumi/trustchain-superapp

e83f935

into adrians

Added database files

cac3438

Merge pull request #1 from naklecha/adrians

b61a055

Adrians

TimG-NL had a problem deploying to apk_build April 24, 2023 10:46 — with GitHub Actions Failure

AdiDumi added 2 commits April 24, 2023 12:52

change list

97760d5

Merge remote-tracking branch 'origin/modularity_integration' into mod…

148430f

…ularity_integration

AdiDumi had a problem deploying to apk_build April 24, 2023 10:53 — with GitHub Actions Failure

Update README.md

ddd4568

TimG-NL had a problem deploying to apk_build April 24, 2023 10:55 — with GitHub Actions Failure

Robert-ML had a problem deploying to apk_build April 24, 2023 11:03 — with GitHub Actions Failure

Robert-ML and others added 2 commits April 24, 2023 13:04

addition to readme

0e8cf40

Update README.md

bfe908d

TimG-NL had a problem deploying to apk_build April 24, 2023 11:09 — with GitHub Actions Failure

Update README.md

aeab75f

TimG-NL had a problem deploying to apk_build April 24, 2023 11:09 — with GitHub Actions Failure

synctext requested a review from OrestisKan April 24, 2023 11:43

Update README.md

ec8eaa7

TimG-NL had a problem deploying to apk_build April 24, 2023 11:43 — with GitHub Actions Failure

managed to work the transaction history and web of trust

a2f4945

AdiDumi had a problem deploying to apk_build April 24, 2023 14:48 — with GitHub Actions Failure

OrestisKan requested changes Apr 24, 2023

View reviewed changes

solved most of the PR comments

b75a42b

AdiDumi temporarily deployed to apk_build April 26, 2023 09:58 — with GitHub Actions Inactive

added bigger pictures and new layout for transaction history

93d75b0

AdiDumi had a problem deploying to apk_build May 17, 2023 12:22 — with GitHub Actions Failure

solved PR comments

b9a416d

Robert-ML had a problem deploying to apk_build May 18, 2023 19:59 — with GitHub Actions Failure

changed info message to resamble button name

1af552a

Robert-ML requested a review from OrestisKan May 19, 2023 12:51

Update README.md

d63ecde

Robert-ML had a problem deploying to apk_build May 22, 2023 07:51 — with GitHub Actions Failure

synctext mentioned this pull request Jul 12, 2023

msc placeholder: LLM as a Google alternative Tribler/tribler#7438

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline Digital Euro #157

Offline Digital Euro #157

Robert-ML commented Apr 24, 2023

OrestisKan left a comment

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

Robert-ML May 18, 2023

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

Robert-ML May 18, 2023

OrestisKan Apr 24, 2023

Robert-ML May 18, 2023

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

OrestisKan Apr 24, 2023

Robert-ML commented May 18, 2023

		// @Query("DELETE FROM userdata_table")
		// suspend fun deleteUserData()


		adapter.registerRenderer(TransactionItemRenderer())

		lifecycleScope.launchWhenResumed {

Offline Digital Euro #157

Are you sure you want to change the base?

Offline Digital Euro #157

Conversation

Robert-ML commented Apr 24, 2023

OrestisKan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Robert-ML commented May 18, 2023