Blockchain Engineering: Token Transaction Engine III #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing implementation of sending a token authenticated with ipv8 overlay.
Token basic structure
…1/trustchain-superapp into feature/initial_token_sending
…1/trustchain-superapp into feature/initial_token_sending
Transaction with local host: - proposal half-block - sign and send proposal half-block - agreement half-block - sign and send agreement half-block Decide to agree a proposal receive trough a pop-up message
…integrate with TrustChainApplication.kt and automaticly build the interfaces for database functions etc
To find new peers, first use the button "find peers", then it is possible to send proposal and receive agreement among 2 different peers. Problems: - Inconsistent. Sometimes blocks are not received
Initial Token Transactions
Merge mainline tribbler into our fork
OrestisKan
reviewed
Apr 21, 2023
| val record = rowView.findViewById(R.id.item_number) as TextView | ||
| val token_id = rowView.findViewById(R.id.item_id) as TextView | ||
|
|
||
| record.text = "Group:" + (token.tokenIntId / groupAmount) + " Token ID: " + token.tokenIntId |
There was a problem hiding this comment.
Using format strings is better
Comment on lines
+96
to
+98
| var newID = uid | ||
| if (sendingToSelf) { | ||
| newID = UUID.randomUUID().toString() |
There was a problem hiding this comment.
I don't see the Id being being incremented just randomized
| var newID = uid | ||
| //Log.d(LOGTAG, "Sending to self: $sendingToSelf") | ||
| if (sendingToSelf) { | ||
| newID = UUID.randomUUID().toString() |
There was a problem hiding this comment.
Again just random not incremented
| * Receive a grouped token agreement block and remove tokens from personal database | ||
| * @param block: The agreement block | ||
| */ | ||
| @Suppress("UNCHECKED_CAST") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Token Transaction Engine for use in DeToks. More information can be found in the README