Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root fragment is not being displayed after we call resetCurrentTa… #57

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

MertNYuksel
Copy link
Member

@MertNYuksel MertNYuksel commented Oct 2, 2024

Fix root fragment is not being displayed after we call resetCurrentTab following activity recreation

We were creating a new fragment instead of using the fragment tag that's already in FragmentManager

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Switch Tab
  • Start a new fragment
  • Trigger activity recreation or process death
  • Click reset current tab without resetting root
  • Ensure that root fragment is displayed properly

Motivation and Context

How Has This Been Tested?

Manual and with an instrumentation test.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MertNYuksel MertNYuksel merged commit 10518de into master Oct 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant