Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix flaky test #3828

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Chore: Fix flaky test #3828

merged 1 commit into from
Feb 13, 2025

Conversation

erindru
Copy link
Collaborator

@erindru erindru commented Feb 13, 2025

After #3818 was merged there appears to be a timing issue in test_context::test_plan_runs_audits_on_dev_previews.

In particular, the error switches between 22 and 10 rows. The actual number of rows doesn't matter to this test, it just checks that the usually blocking audit ran at all and was automatically switched to non-blocking.

This PR relaxes the string matching on the output

@lafirm lafirm mentioned this pull request Feb 13, 2025
@erindru erindru merged commit 6898aaf into main Feb 13, 2025
21 checks passed
@erindru erindru deleted the erin/fix-flaky-test branch February 13, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants