Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ratatui to 0.26.1 #3

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

albinekb
Copy link
Contributor

@albinekb albinekb commented Mar 9, 2024

Thanks for making this! It's fun to play with 👏 I wanted to use the latest ratatui, and there was some minor changes needed. LMK if there's anything i need to change.

@TheEmeraldBee
Copy link
Owner

One of the tests is failing. If you could look at that and either change the test or fix that, that would be great, and I can then accept the pull request. Thank you!

@albinekb
Copy link
Contributor Author

albinekb commented Mar 9, 2024

The test failed because:

  left: Rect { x: 26, y: 125, width: 204, height: 3 }
 right: Rect { x: 26, y: 128, width: 204, height: 3 }

Breaking change in 0.25:
ratatui/ratatui#881

Should we keep using Legacy flex, so it behaves like before? (pushed commit)
Let me know if you'd like to use the new default Flex::Start and update the expected result in the test instead.

@TheEmeraldBee
Copy link
Owner

Lets update it.

@albinekb
Copy link
Contributor Author

albinekb commented Mar 9, 2024

Great! Fixed ✅

@TheEmeraldBee TheEmeraldBee merged commit 30363be into TheEmeraldBee:master Mar 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants