Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default descriptions for built-in vim commands #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luqasn
Copy link
Contributor

@luqasn luqasn commented Jan 29, 2025

instead of relying on command names from IdeaVIM as description.
This also changes the behaviour of the WhichKey_ShowVimActions option
to not show all options but only those that have a description set -
either via the defaults or provided by the user.

instead of relying on command names from IdeaVIM as description.
This also changes the behaviour of the `WhichKey_ShowVimActions` option
to not show all options but only those that have a description set -
either via the defaults or provided by the user.
@luqasn
Copy link
Contributor Author

luqasn commented Jan 30, 2025

I filtered the which-key.nvim presets to only copy the normal mode descriptions, was that correct?
What was confusing me is that you can't specify which mode the command is valid for when setting the description in idea-which-key

@TheBlob42
Copy link
Owner

That is a point I have never ever thought about 😅
I guess it was overlooked as it just checks the currently available mappings based on the code and then goes through "all" descriptions. As long as you don't have the same key sequences for different mappings in different modes you would not notice the issue. I have to check the code when I find the time for this (same goes for testing your changes)

@luqasn
Copy link
Contributor Author

luqasn commented Feb 4, 2025

Some of these don't work yet because of #89 (the window commands)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants