Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Address shellcheck error and warnings #18

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Address shellcheck error and warnings #18

merged 11 commits into from
Jan 26, 2024

Conversation

lamchau
Copy link
Contributor

@lamchau lamchau commented Jan 25, 2024 •
edited
Loading

  • addressed a handful of shellcheck warnings and errors
  • applied shfmt for consistent style, used env bash for portability
  • use --long-options for self-documenting features
  • added color support for logging (RED and YELLOW were unused, but I think I captured the intent of where they might be used
  • replace color escape codes with tput for unsupported/non-tty $TERMs

@michaelneale michaelneale merged commit 11bc1ed into TBD54566975:main Jan 26, 2024
1 check passed
@lamchau lamchau deleted the lam/shellcheck-scripts branch January 26, 2024 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelneale michaelneale michaelneale approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamchau @michaelneale