feat: JVM can make local verb calls via generated clients #3299
Conversation
tomdaffurn
requested review from
stuartwdouglas
and removed request for
a team
| @@ -905,6 +905,10 @@ func (e *Engine) buildWithCallback(ctx context.Context, callback buildCallback, | |||
| return err | |||
| } | |||
| } | |||
| err = WriteGenericSchemaFiles(newSchemas, metasMap) | |||
There was a problem hiding this comment.
So this approach will write out the generated schema after the build, which then results in clients being generated?
Won't this also generate new copies of things like Data classes that will then be duplicated?
I guess with this approach you have to check the schema in, as projects won't be buildable otherwise.
There was a problem hiding this comment.
This doesn't change the approach much. Previously it wrote schema files inside the generate stubs function on line 903. Stubs are only written for modules not in the last topology group. ie modules that have dependant modules.
Now it does the same but outside the if statement, for every group in the topology.
Yes, it does generate duplicated data classes, so when using the verb client you need to use the ftl.module.DataClass package instead of your own. That's a bit sucky.
Maybe we can change the codegen to special case local verb clients...
No description provided.