task/WP-857 & 858: View submissions updates

[edmondsgarrett]

Overview

Adds payor code column + filter to admin view submissions and adjusts backend to accommodate org name info for "translating" payor code to org name
…

Related

• WP-857
• WP-858

…

Changes

• Add submitters.org_name to both get submission db queries for use as payor codes on each listing
• Adjusts respective views for both user and admin submissions listings to accommodate db query updates
• Adds submitters.org_name to common_api entities view for sorting purposes
• Adds payor code column and filter dropdown to admin submissions listing
• Adjusts "No Data Available" message on both tables to span by # columns in header (previously hard-coded number)
  …

Testing

1. Go to http://localhost:8000/submissions/list-submissions/ and confirm payor code now shows an organization name rather than an 8-digit code, and test for regressions
2. Go to http://localhost:8000/administration/list-submissions/ and confirm there is an additional 'Payor Code' column showing the same info as previous page
3. Test payor code filter and confirm it filters as expected

UI

…

Notes

• Admin submissions payor code filter populates very slowly, takes a lot of time from when page loads (seen minimum 10-12 sec), not sure where the slowdown is occurring, narrowed it down to the get_submitter_info db query
  …

[chandra-tacc]

added couple required changes.

[chandra-tacc]

To prevent non admin users from request data just by using query param.

Suggested change

	from_admin = json.loads(request.GET.get('from_admin', False)) # for admin submissions page, need all submitters, not just for requesting user
	from_admin = json.loads(request.GET.get('from_admin', False)) # for admin submissions page, need all submitters, not just for requesting user
	if from_admin and not is_apcd_admin(request.user):
	return JsonResponse({'error': 'Unauthorized'}, status=403)