Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use input column statistics for computing IF min/max statistics #55922

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −1
Open

[Enhancement] Use input column statistics for computing IF min/max statistics #55922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e/src/main/java/com/starrocks/sql/optimizer/statistics/ExpressionStatisticCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,11 @@ private ColumnStatistic multiaryExpressionCalculate(CallOperator callOperator,
case FunctionSet.IF:
distinctValues = childColumnStatisticList.get(1).getDistinctValuesCount() +
childColumnStatisticList.get(2).getDistinctValuesCount();
return new ColumnStatistic(Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY, 0,
double minValue = Math.min(childColumnStatisticList.get(1).getMinValue(),
childColumnStatisticList.get(2).getMinValue());
double maxValue = Math.max(childColumnStatisticList.get(1).getMaxValue(),
childColumnStatisticList.get(2).getMaxValue());
return new ColumnStatistic(minValue, maxValue, 0,
callOperator.getType().getTypeSize(), distinctValues);
// use child column statistics for now
case FunctionSet.SUBSTRING:
Expand Down
24 changes: 24 additions & 0 deletions .../test/java/com/starrocks/sql/optimizer/statistics/ExpressionStatisticsCalculatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,4 +632,28 @@ public void testFromDays() {
Assert.assertEquals(columnStatistic.getMaxValue(), 2.534021856E11, 0.001);
Assert.assertEquals(columnStatistic.getMinValue(), -28800.0, 0.001);
}

@Test
public void testIF() {
ColumnRefOperator column = new ColumnRefOperator(1, Type.INT, "column", true);
BinaryPredicateOperator condition = new BinaryPredicateOperator(BinaryType.EQ, column, ConstantOperator.createInt(1));
ColumnRefOperator left = new ColumnRefOperator(0, Type.INT, "left", true);
ColumnRefOperator right = new ColumnRefOperator(1, Type.INT, "right", true);

ColumnStatistic columnStatistic = new ColumnStatistic(-300, 300, 0, 0, 300);
ColumnStatistic leftStatistic = new ColumnStatistic(-100, 100, 0, 0, 100);
ColumnStatistic rightStatistic = new ColumnStatistic(100, 200, 0, 0, 100);

Statistics.Builder builder = Statistics.builder();
builder.setOutputRowCount(300);
builder.addColumnStatistic(column, columnStatistic);
builder.addColumnStatistic(left, leftStatistic);
builder.addColumnStatistic(right, rightStatistic);

CallOperator callOperator = new CallOperator(FunctionSet.IF, Type.INT, Lists.newArrayList(condition, left, right));
ColumnStatistic ifStatistic = ExpressionStatisticCalculator.calculate(callOperator, builder.build());
Assert.assertEquals(ifStatistic.getDistinctValuesCount(), 200, 0.001);
Assert.assertEquals(ifStatistic.getMaxValue(), 200, 0.001);
Assert.assertEquals(ifStatistic.getMinValue(), -100, 0.001);
}
}
Loading