[Refactor] Remove charge_mode from LRUCache #55911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinMar
reviewed
Feb 14, 2025
| void (*deleter)(const CacheKey& key, void* value), CachePriority priority, | ||
| size_t value_size) { | ||
| Cache::Handle* LRUCache::insert(const CacheKey& key, uint32_t hash, void* value, size_t value_size, size_t charge, | ||
| void (*deleter)(const CacheKey& key, void* value), CachePriority priority) { |
There was a problem hiding this comment.
If the value is self-descriptive, how about removing the value_size in the lru_cache because it is really unnecessary for a underly cache? It can reduce memory if value_size=charge in many cases. If value_size!=size, the caller can get the value size from the pointer.
There was a problem hiding this comment.
Good suggestion. Removing it can save metadata memory. However, we won't change it in this PR. The purpose of this PR is to enable PageCache to use the StarCache interface.
GavinMar
approved these changes
Feb 14, 2025
|
@Mergifyio rebase main |
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
Signed-off-by: trueeyu <[email protected]>
✅ Branch has been successfully rebased |
trueeyu
force-pushed
the
cache_unit_8
branch
from
1e7162b to
b7d2c00
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 25 / 25 (100.00%) file detail
|
kevincai
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
charge_sizeis the actual memory size occupied by an element, whilevalue_sizeis the size of the element. For the underlying cache, it only needs to knowcharge_sizefor memory accounting purposes. As for the passed-in Item, if it needs to rely on thevalue_sizefor decoding, then ensuring that the data structure is self-descriptive.The interface of
DataCacheonly have one paramcharge_size, so In order to unifyPageCacheandDataCache, the charge mode ofLRUCachewill be removed.What I'm doing:
Remove charge_mode from LRUCache
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: