Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] avoid redundant directory creation when create file block (backport #55716) #55879

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 13, 2025

Why I'm doing:

After version 3.3, we support spilling operator intermediates to remote object storage. However, in the current implementation, every time a block is allocated, it checks whether the directory exists, resulting in unnecessary API calls and latency.

What I'm doing:

This pull request includes changes to the FileBlockManager class to optimize the creation of directories in the file block manager. The most important changes involve adding a check to avoid redundant directory creation and introducing a new member variable to track the last created directory.

Optimization of directory creation:

  • be/src/exec/spill/file_block_manager.cpp: Added a check to ensure that the directory is only created if it has not been created before, reducing unnecessary filesystem operations. ([be/src/exec/spill/file_block_manager.cppR237-R240](https://github.com/StarRocks/starrocks/pull/55879/files#diff-3bb4fc69ffe78e61658f4b5aa8ac78514b11550a0c87a1781c33d6a9d19a5e02R237-R240))
  • be/src/exec/spill/file_block_manager.h: Introduced a new member variable _last_created_container_dir to store the path of the last created directory, which is used in the aforementioned check. ([be/src/exec/spill/file_block_manager.hR51](https://github.com/StarRocks/starrocks/pull/55879/files#diff-80a364cbfceb51fff006948ceed1b690236ad393f2fca768cf22032eb88b34e9R51))

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit 39a026e into branch-3.3 Feb 13, 2025
35 of 36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-55716 branch February 13, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants