[BugFix] Fix edit log hole error caused by JournalWriter throwing uncached exception #55836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HangyuanLiu
approved these changes
Feb 12, 2025
kevincai
approved these changes
Feb 12, 2025
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
fix_edit_log_hole_bug_journal_writer
branch
from
bcf095f to
0c625b7
Compare
|
@Mergifyio rebase |
Signed-off-by: gengjun-git <[email protected]>
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
fix_edit_log_hole_bug_journal_writer
branch
from
0c625b7 to
db74aee
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 0 / 3 (00.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.0 |
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ached exception (#55836) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0b6292)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ached exception (#55836) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0b6292)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ached exception (#55836) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0b6292)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ached exception (#55836) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0b6292)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ached exception (#55836) Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit f0b6292)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ached exception (backport #55836) (#56016) Co-authored-by: gengjun-git <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ached exception (backport #55836) (#56017) Co-authored-by: gengjun-git <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ached exception (backport #55836) (#56013) Co-authored-by: gengjun-git <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ached exception (backport #55836) (#56015) Co-authored-by: gengjun-git <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ached exception (backport #55836) (#56014) Co-authored-by: gengjun-git <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Regardless of what exception is thrown by writeOneBatch, the system should exit. If the next round of writeOneBatch is executed successfully, an edit log hole error will be generated because the log data in the queue has been lost.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: