Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] catch TransactionState afterStateTransform exception after commit (backport #55738) #55738

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

starrocks-xupeng
Copy link
Contributor

@starrocks-xupeng starrocks-xupeng commented Feb 10, 2025

Why I'm doing:

What I'm doing:

partition's nextVersion will not be properly set if afterStateTransform(TransactionStatus.COMMITTED) throws exception, which will lead to 2 txns share the same version

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@starrocks-xupeng starrocks-xupeng changed the title [BugFix] catch TransactionState afterStateTransform exception [BugFix] catch TransactionState afterStateTransform exception (backport #55738) Feb 10, 2025
@starrocks-xupeng starrocks-xupeng changed the title [BugFix] catch TransactionState afterStateTransform exception (backport #55738) [BugFix] catch TransactionState afterStateTransform exception after commit (backport #55738) Feb 10, 2025
luohaha
luohaha previously approved these changes Feb 11, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wyb wyb merged commit 2654728 into StarRocks:branch-3.2 Feb 14, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants