[BugFix] flatjson read notObject json crash #55661
Open
+120
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seaven <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| builder.close(); | ||
| auto slice = builder.slice(); | ||
| _json_result->append(JsonValue(slice)); | ||
| _null_result->append(slice.isEmptyObject()); | ||
| } | ||
| } else { | ||
| for (size_t i = 0; i < rows; i++) { |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential use of nullptr when calling obj->to_vslice() without checking if obj is not null.
You can modify the code like this:
auto obj = remain->get_object(i);
if (!obj) {
// Handle null object appropriately
_json_result->append(JsonValue()); // Or any other handling mechanism
_null_result->append(true); // Assuming null should be treated as empty
continue;
}
auto vs = obj->to_vslice();
if (obj->is_invalid()) {
vpack::Builder builder;
builder.add(vpack::Value(vpack::ValueType::Object));
_merge_json(_src_root.get(), &builder, i);
builder.close();
auto slice = builder.slice();
_json_result->append(JsonValue(slice));
_null_result->append(slice.isEmptyObject());
} else if (!vs.isObject()) {
for (int k = 0; k < _src_paths.size(); k++) {
// check child column should be null
DCHECK(_src_columns[k]->is_null(i));
}
_json_result->append(JsonValue(vs));
_null_result->append(vs.isEmptyObject());
} else {
vpack::Builder builder;
builder.add(vpack::Value(vpack::ValueType::Object));
_merge_json_with_remain<IN_TREE>(_src_root.get(), &vs, &builder, i);
builder.close();
auto slice = builder.slice();
_json_result->append(JsonValue(slice));
_null_result->append(slice.isEmptyObject());
}
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
like
insert into js8 values (11, parse_json('1985-07-10 01:35:29'));the remain json will be
'1985-07-10 01:35:29', not object, need special processFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: