Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Drop inexistent table silently #50150

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[BugFix] Drop inexistent table silently #50150

merged 1 commit into from
Aug 23, 2024

Conversation

letian-jiang
Copy link
Contributor

@letian-jiang letian-jiang commented Aug 22, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/8374

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@letian-jiang
update
0ef3f7f 
Signed-off-by: Letian Jiang <[email protected]>
@letian-jiang letian-jiang requested review from a team as code owners August 22, 2024 08:23
@github-actions github-actions bot added the 3.3 label Aug 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 8 / 10 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/HiveMetadata.java 3 4 75.00% [180]
🔵 com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java 5 6 83.33% [1501]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) August 23, 2024 04:56
@dirtysalt dirtysalt merged commit aeff4a3 into StarRocks:main Aug 23, 2024
47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 23, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
@letian-jiang @mergify
[BugFix] Drop inexistent table silently (#50150)
1fabe02 
Signed-off-by: Letian Jiang <[email protected]>
(cherry picked from commit aeff4a3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetadata.java
@mergify mergify bot mentioned this pull request Aug 23, 2024
Merged
42 tasks
@silverbullet233 silverbullet233 mentioned this pull request Aug 27, 2024
Merged
24 tasks
wanpengfei-git pushed a commit that referenced this pull request Aug 28, 2024
@mergify @letian-jiang @dirtysalt
[BugFix] Drop inexistent table silently (backport #50150) (#50195)
3e247c5 
Signed-off-by: yanz <[email protected]>
Co-authored-by: Letian Jiang <[email protected]>
Co-authored-by: yanz <[email protected]>
@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
42 tasks
@zombee0
Copy link
Contributor

zombee0 commented Feb 14, 2025

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2025
@letian-jiang @mergify
[BugFix] Drop inexistent table silently (#50150)
abb5fba 
Signed-off-by: Letian Jiang <[email protected]>
(cherry picked from commit aeff4a3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/hive/HiveMetadata.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java
@mergify mergify bot mentioned this pull request Feb 14, 2025
Closed
18 tasks
zombee0 pushed a commit to zombee0/starrocks that referenced this pull request Feb 14, 2025
@letian-jiang @zombee0
[BugFix] Drop inexistent table silently (StarRocks#50150)
c5f5a1e 
Signed-off-by: Letian Jiang <[email protected]>
@zombee0 zombee0 mentioned this pull request Feb 14, 2025
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@packy92 packy92 packy92 approved these changes

Assignees

@letian-jiang letian-jiang

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@letian-jiang @zombee0 @dirtysalt @packy92