Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use input column statistics for computing IF min/max statistics #55922

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-selmi
Copy link

@m-selmi m-selmi commented Feb 14, 2025

Why I'm doing:

Currently the IF function uses the Double.NEGATIVE_INFINITY and Double.POSITIVE_INFINITY as its min value and max value estimation. This is not ideal for predicate selectivity evaluation and can be easily improved.

What I'm doing:

Since if(expr1,expr2,expr3) returns values from either expr2 or expr3 we can use their min and max values to better estimate the output.
For example for IF(expr1,1,2) we can set the min value to 1 and the max value to 2.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@m-selmi m-selmi requested a review from a team as a code owner February 14, 2025 10:22
@m-selmi m-selmi force-pushed the enhance-if-function-statistics branch from 25f38b3 to 20f9408 Compare February 14, 2025 10:28
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants