[Enhancement] avoid redundant directory creation when create file blo…

…ck (#55716) Signed-off-by: luohaha <[email protected]>
StarRocks · Feb 13, 2025 · 9c1f813 · 9c1f813
1 parent 1920151
commit 9c1f813
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/be/src/exec/spill/file_block_manager.cpp b/be/src/exec/spill/file_block_manager.cpp
@@ -234,7 +234,10 @@ StatusOr<FileBlockContainerPtr> FileBlockManager::get_or_create_container(const
                     << plan_node_name;
     uint64_t id = _next_container_id++;
     std::string container_dir = dir->dir() + "/" + print_id(_query_id);
-    RETURN_IF_ERROR(dir->fs()->create_dir_if_missing(container_dir));
+    if (_last_created_container_dir != container_dir) {
+        RETURN_IF_ERROR(dir->fs()->create_dir_if_missing(container_dir));
+        _last_created_container_dir = container_dir;
+    }
     ASSIGN_OR_RETURN(auto block_container, FileBlockContainer::create(dir, _query_id, fragment_instance_id,
                                                                       plan_node_id, plan_node_name, id, block_size));
     RETURN_IF_ERROR(block_container->open());

diff --git a/be/src/exec/spill/file_block_manager.h b/be/src/exec/spill/file_block_manager.h
@@ -48,6 +48,7 @@ class FileBlockManager : public BlockManager {
 
     TUniqueId _query_id;
     std::atomic<uint64_t> _next_container_id = 0;
+    std::string _last_created_container_dir;
 
     DirManager* _dir_mgr = nullptr;
 };