feat: add missing thumbnail and user details #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wielopolski
requested review from
typeWolffo,
piotr-pajak and
mateuszszczecina
and removed request for
typeWolffo
piotr-pajak
approved these changes
Jan 16, 2025
| import type { CourseListLayout } from "~/types/shared"; | ||
|
|
||
| export const CourseList: React.FC<{ | ||
| availableCourses: GetAllCoursesResponse["data"]; | ||
| courses: GetAvailableCoursesResponse["data"]; |
There was a problem hiding this comment.
Can we stay with old name?
Suggested change
| courses: GetAvailableCoursesResponse["data"]; | |
| availableCourses: GetAvailableCoursesResponse["data"]; |
wielopolski
force-pushed
the
mw_feat_missing_user_details
branch
from
7d3055c to
9b700e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
LC-586
Overview
This PR adds missing thumbnail handler, user details and refactors courses response type.