-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding WaitForDownload test for .NET #1885
base: trunk
Are you sure you want to change the base?
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
@halex2005 can you please sign the CLA? |
@diemol, signed |
looks like the failing check is unrelated @diemol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@halex2005 resolve conflicts for this PR, please.
Code LGTM.
User description
Hi!
Description
I've added WaitForDownload test case for .NET.
Review, please.
Note, that I've also added
--no-sandbox
switch to ChromeOptions because chrome crashes without it.It's to make sure that tests are green.
Types of changes
Checklist
PR Type
Tests, Enhancement
Description
WaitForDownload
test method inNetworkTest.cs
to handle and verify file downloads.BaseTest.cs
by adding a--no-sandbox
argument to ChromeOptions to prevent Chrome crashes during tests.Changes walkthrough 📝
BaseTest.cs
Add no-sandbox argument to ChromeOptions
examples/dotnet/SeleniumDocs/BaseTest.cs
--no-sandbox
argument to ChromeOptions.NetworkTest.cs
Add WaitForDownload test method for file downloads
examples/dotnet/SeleniumDocs/BiDi/CDP/NetworkTest.cs
WaitForDownload
test method.network.en.md
Update CSharp tab with code block reference
website_and_docs/content/documentation/webdriver/bidi/cdp/network.en.md
network.ja.md
Update CSharp tab with code block reference
website_and_docs/content/documentation/webdriver/bidi/cdp/network.ja.md
network.pt-br.md
Update CSharp tab with code block reference
website_and_docs/content/documentation/webdriver/bidi/cdp/network.pt-br.md
network.zh-cn.md
Update CSharp tab with code block reference
website_and_docs/content/documentation/webdriver/bidi/cdp/network.zh-cn.md