-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Get-Manifest): Select actual source for manifest #6142
Open
HUMORCE
wants to merge
21
commits into
ScoopInstaller:develop
Choose a base branch
from
HUMORCE:refctor/parse_app-n-get-manifest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(Get-Manifest): Select actual source for manifest #6142
HUMORCE
wants to merge
21
commits into
ScoopInstaller:develop
from
HUMORCE:refctor/parse_app-n-get-manifest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HUMORCE
changed the title
refactor(core): Parse/Select installed apps/manifests first
refactor(Get-Manifest): Select actual source for installed manifest
Sep 20, 2024
- Mark URI(path/URL/UNC/etc.) query as standalone manifest - Drop `installed` and `available update` items for [query] and [installed] are different sources.
HUMORCE
changed the title
refactor(Get-Manifest): Select actual source for installed manifest
refactor(Get-Manifest): Select actual source for manifest
Sep 21, 2024
- Query for remote manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODOs:
scoop-list
resultMotivation and Context
Relates to #2719, #3441, #3870, #5172, #5709
How Has This Been Tested?
before: LEFT pane, after: RIGHT pane
f6ce496: Select actual source for manifest
manifests with same name from different bucket:
manifest that installs with URI:
Fallback to installed manifest:
e7155ea: handling deprecated manifest
c525005:
standalone manifest: any query or installation that does not install with app name, e.g. PATH or URI
result of
scoop-info
will drop Installed version and available update when source of queried and installed are different.BOTH pane are after effects
c38fc63: depends support for standalone manifest
a65c84a: deprecated tag/mark on scoop-list
61b3259: show message when multiple buckets contain [querying app]
Checklist:
develop
branch.