fix(install)!: show fs type and abort if Junction creation fails (#5367) #6052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if Scoop is running on exFAT or other filesystems with no Junction (a.k.a. Directory Junction) support, Scoop will fail to install app during
link app_name\current => app_name\0.0.1
.If
mklink
is used, it will promptLocal NTFS volumes are required to complete the operation.
. But forNew-Item
, a meaningless error will show, making it hard to debug.This may be a BREAKING CHANGE, for it directly executes
abort
rather than continue with error.Motivation and Context
Relates to #5367
How Has This Been Tested?
I applied this patch and and added the following code locally, and run Scoop with
scoop install adb
:The linking is failed as expected, and the following output is shown:
for the Docker part, i've done similar test.
Checklist:
develop
branch.I may be slow to respond. If there is any change, feel free to directly edit!