fix(update): Do not uninstall the entire app when updating, add pre_update
#5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent user data loss, don't trigger `pre_uninstall`, `post_uninstall` and `uninstaller`. The `pre_update` hook will be triggered instead of `post_uninstall`.
ltguillaume
changed the title
pre_updatepre_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent user data loss, don't trigger
pre_uninstall,post_uninstallanduninstallerwhen updating (example: Spotify). Thepre_updatehook will be triggered instead ofpost_uninstall, so that separate operations before an update can (still) be specified.Motivation and Context
People will lose their user data with the current handling of updates.
Relates to #5648
How Has This Been Tested?
NO. I do not have the means or the knowledge to properly test this.
Checklist:
developbranch.