Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ishanavasthi.md #23

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

ishanavasthi
Copy link
Contributor

@ishanavasthi ishanavasthi commented Sep 19, 2023

Description:

This pull request adds a new member file under the members folder as mentioned in #1. The file is named ishanavasthi.md and contains my name and GitHub Username.

Changes:

Added ishanavasthi.md in the members folder.

Copy link
Contributor

@AbhinavGupta-de AbhinavGupta-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using emoji's let's keep simple issue tittles.

Also try to write meaningful commit names and provide some description to the pull request. It can be as simple as the link to issue it solves and some basic information or you can also follow #18 example.

@ishanavasthi ishanavasthi changed the title Create ishanavasthi.md 🤩 Create ishanavasthi.md Sep 20, 2023
@ishanavasthi
Copy link
Contributor Author

Also try to write meaningful commit names and provide some description to the pull request. It can be as simple as the link to issue it solves and some basic information or you can also follow #18 example.

@AbhinavGupta-de If the pull was something significant and worth writing a description for, I would have done that. This one is not significant enough to warrant a description. What's the point of doing that here?

@AbhinavGupta-de
Copy link
Contributor

@ishanavasthi True but the point of doing this is we get habitual of writing good description and adapt to good pratices whenver we are making contributions anywhere no matter how small the contirbution is 👍

@AbhinavGupta-de AbhinavGupta-de merged commit 5bad115 into SST-OSS:main Sep 20, 2023
@2k4sm 2k4sm mentioned this pull request Sep 20, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants