Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle tiny keys #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: handle tiny keys #459

wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Member

There is an issue with very small keys, that were not properly handled.

This fixes the issue in two forms

  • introduce a minimum size of 16 bits for the modulus
  • avoid using - to avoid a subtraction with overflow

@tarcieri
Copy link
Member

I’m reminded of #445

@dignifiedquire
Copy link
Member Author

yes, but the goal here is not general security, but rather for a first step remove unusable keys

once we have a solution for #445 this can be folded in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri Awaiting requested review from tarcieri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @tarcieri