Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment jack_set_port_rename_callback() since it seems to work #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xkr47
Copy link

@xkr47 xkr47 commented Aug 13, 2023

Comment suggested "doesn't compile for testing since it is a weak export" but I was able to compile and run tests just fine. I have Linux / Devuan with jack2 (not pipewire).

A few tests were failing, but commenting or uncommenting the code did not affect the outcome.

I changed this since I maintain a program to automatically update connections based on which (jack) clients and ports are present and I noticed Ardour seems to rename ports.. and I would prefer to not having to request a full list of ports and connections on every event..

Thanks for your great lib!

Comment suggested "doesn't compile for testing since it is a weak export" but I was able to compile and run tests just fine. I have Linux / Devuan with jack2 (not pipewire).
@xkr47
Copy link
Author

xkr47 commented Aug 24, 2023

For the record, I checked all the build errors and all of them are "remove this call to default". A lot of them are AudioIn::default(), which is also the documented way of producing an AudioIn. So it seems to me that the correct remedy to this would be to add #![allow(clippy::default-constructed-unit-structs)] in the right places. Wdyt? I can look into creating a separate PR if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant