remove thiserror dependency
#633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseluis
force-pushed
the
remove-thiserror
branch
from
42d8cf6
to
309c8a9
Compare
joseluis
force-pushed
the
remove-thiserror
branch
from
309c8a9
to
1df1425
Compare
Agreed. While I generally love thiserror, rodio is used a lot so a small save in compile time has a big impact all together. LGTM 👍 |
dvdsk
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this comment on the commit that added support for Symphonia, regarding it as an unneccesary and cumbersome dependency, which I subscribe 100%, and since it's a simple change I just did it.