Add support for scope related queries #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Sorry for the (very) late review. As a person with merge rights to a repo, I should be watching it on github.
I think this is pretty good. It's tough to tell from the github view but I think this is a non-breaking change. I'll test it out locally and merge it.
Comment on lines
+189
to
+195
| macro_rules! try_status_or_return { | ||
| ($status:expr) => { | ||
| if $status != kAudioHardwareNoError as i32 { | ||
| return Err(Error::Unknown($status)); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Given that you're only using this macro once, declaration and use makes it a bit harder to understand. Let's just use the oh I see, this was here before.if status != ... { return Err(...)} What do you think?
|
Thanks @simlay! Can I bug you for a release with this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
get_audio_device_ids_for_scopewhich returns devices that are listed under a specific scope instead of just global andget_audio_device_supports_scopewhich checks if a specific devices has any channels for a scope.This is basically a cleanup of #94