Call XCloseDisplay instead of xcb_disconnect

[glowcoil]

Pass false for the should_drop argument of XCBConnection::from_raw_xcb_connection, so that it doesn't implicitly call xcb_disconnect on drop. Instead, explicitly call XCloseDisplay on drop, since the connection was originally created with XOpenDisplay.

[prokopyl]

The fix looks good to me, although I'm not sure why we're even dealing with XOpenDisplay / XCloseDisplay instead of using XCBConnection::connect()?

I'll merge this now, if we want to make those broader changes we can do so in another PR. 🙂

[glowcoil]

I'm not sure why we're even dealing with XOpenDisplay / XCloseDisplay instead of using XCBConnection::connect()?

It's necessary since we use the Xlib GLX API for OpenGL context creation. If we were to switch from GLX to EGL, it should be possible to stop linking to Xlib and xcb entirely and just use x11rb's RustConnection.