-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prototypes in extension code #36
Conversation
Fixes a few deprecation warnings such as Return type of Tensor\Vector::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hey this is great @myfluxi, I'll take a look at this ASAP |
Seems something is broken here ? |
It is an unrelated test failing later in the process. This patch fixes some warnings which at least lets the extension compile during testing. |
Hey thanks fellas, much appreciated! Do we still need this code since we merged @mlocati's code? |
Closing this because I think this issue has been solved in a different PR. |
Fixes a few deprecation warnings such as
Return type of Tensor\Vector::getIterator() should either be compatible with
IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be
used to temporarily suppress the notice in Unknown on line 0