Make DateTime parameters culture invariant #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already done with a commit I made a while ago, but undone. It might be beneficial to fix the botched merge of all my code by @faniereynders |
|
I had to merge plenty of PRs at the time and had to manually resolve the conflicts. This led to possible feature loss. Hopefully things will start to stabilize now. |
|
Thanks @nillis for your contribution! |
|
Thanks to you for the fast response! And for the great library I've been using for 6 months now. |
|
@nillis if you're interested in helping out as an official contributor, let me know. Would be great to expand on the core team. |
faniereynders
added a commit
that referenced
this pull request
Jun 16, 2016
* Make DateTime parameters culture invariant (#100) * Make DateTime parameters culture invariant * Make DateTime parameters culture invariant in cs template * Make Nullable<DateTime> culture invariant in tt * Make Nullable<DateTime> culture invariant in cs template * MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) (#104)
faniereynders
added a commit
that referenced
this pull request
Jun 16, 2016
* MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) * Pull from Master (#105) * Make DateTime parameters culture invariant (#100) * Make DateTime parameters culture invariant * Make DateTime parameters culture invariant in cs template * Make Nullable<DateTime> culture invariant in tt * Make Nullable<DateTime> culture invariant in cs template * MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) (#104) * Bumped version * Bumped version * Bumped version
faniereynders
added a commit
that referenced
this pull request
Jun 16, 2016
* MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) * Pull from Master (#105) * Make DateTime parameters culture invariant (#100) * Make DateTime parameters culture invariant * Make DateTime parameters culture invariant in cs template * Make Nullable<DateTime> culture invariant in tt * Make Nullable<DateTime> culture invariant in cs template * MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) (#104) * Bumped version * Bumped version * Bumped version * Update AssemblyInfo.cs
faniereynders
added a commit
that referenced
this pull request
Jun 16, 2016
* MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) * Pull from Master (#105) * Make DateTime parameters culture invariant (#100) * Make DateTime parameters culture invariant * Make DateTime parameters culture invariant in cs template * Make Nullable<DateTime> culture invariant in tt * Make Nullable<DateTime> culture invariant in cs template * MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) (#104) * Bumped version * Bumped version * Bumped version * Update AssemblyInfo.cs * Update AssemblyInfo.cs
faniereynders
added a commit
that referenced
this pull request
Jun 26, 2016
* MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) * Pull from Master (#105) * Make DateTime parameters culture invariant (#100) * Make DateTime parameters culture invariant * Make DateTime parameters culture invariant in cs template * Make Nullable<DateTime> culture invariant in tt * Make Nullable<DateTime> culture invariant in cs template * MyWebApiProxyBaseAddress trailing slash (sans System.Web) (#103) (#104) * Bumped version * Bumped version * Bumped version * Update AssemblyInfo.cs * Update AssemblyInfo.cs * signed assemblies
|
Unfortunately this does not seem to work with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DateTime parameters the default ToString will look into the CurrentCulture to determine the dateformat. This pull request fixes this with the solution proposed in #70 by @wolfen351.