Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import releaselog without try/catch #398

Draft
wants to merge 1 commit into
base: 11.x.x
Choose a base branch
from
Draft

fix: import releaselog without try/catch #398

wants to merge 1 commit into from

Conversation

mamico
Copy link

@mamico mamico commented Nov 9, 2023

No description provided.

pnicolli
pnicolli reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho visto che il test della build si rompe, cerca di importare comunque i file release dagli addon. Non ho mai usato require per codice da compilare per il web, non lo conosco bene. Hai provato con un import dinamico fatto con import() per caso?

src/components/ReleaseLog/ReleaseLog.jsx Show resolved Hide resolved
@mamico mamico marked this pull request as draft November 9, 2023 10:20
@mamico
Copy link
Author

mamico commented Nov 9, 2023

Ho visto che il test della build si rompe, cerca di importare comunque i file release dagli addon. Non ho mai usato require per codice da compilare per il web, non lo conosco bene. Hai provato con un import dinamico fatto con import() per caso?

visto anche io, ho messo in draft, ci guardo.

giuliaghisini
giuliaghisini approved these changes Nov 9, 2023
View reviewed changes
Copy link

@giuliaghisini giuliaghisini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sistemata la ci che si rompe per me va bene

@pnicolli pnicolli changed the base branch from main to 11.x.x August 9, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolli pnicolli pnicolli left review comments

@giuliaghisini giuliaghisini giuliaghisini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamico @pnicolli @giuliaghisini