fix: review fixes

RedTurtle · Feb 6, 2025 · 983a594 · 983a594
1 parent f9dad47
commit 983a594
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 9 deletions.
diff --git a/src/components/ItaliaTheme/Blocks/Listing/Commons/ListingImage.jsx b/src/components/ItaliaTheme/Blocks/Listing/Commons/ListingImage.jsx
@@ -25,7 +25,7 @@ const ListingImage = ({
   noWrapLink = false,
   ...imageProps
 }) => {
-  if (!contentHasImage(item, !imageProps?.image_field)) {
+  if (!contentHasImage(item) && !imageProps?.image_field) {
     if (showDefault) {
       return (
         <ListingImageWrapper item={item} noWrapLink={noWrapLink}>

diff --git a/src/components/ItaliaTheme/Cards/CardPersona.jsx b/src/components/ItaliaTheme/Cards/CardPersona.jsx
@@ -21,7 +21,7 @@ export const CardPersona = ({
   type,
   isEditMode,
 }) => {
-  const hasImage = contentHasImage(item, showImage);
+  const hasImage = contentHasImage(item) && showImage;
 
   return (
     <Card

diff --git a/src/components/ItaliaTheme/View/Commons/GenericCard.jsx b/src/components/ItaliaTheme/View/Commons/GenericCard.jsx
@@ -51,7 +51,7 @@ const GenericCard = ({
     </>
   );
   const cooked_image_field = image_field || item.image_field;
-  const showImage = contentHasImage(item, showimage && cooked_image_field);
+  const showImage = showimage && contentHasImage(item) && cooked_image_field;
 
   return item ? (
     showImage ? (
@@ -62,7 +62,7 @@ const GenericCard = ({
               <Image
                 item={item}
                 imageField={cooked_image_field}
-                alt={item.title ?? ''}
+                alt={''}
                 title={item.title}
               />
             </figure>

diff --git a/src/components/ItaliaTheme/View/Commons/OfficeCard.jsx b/src/components/ItaliaTheme/View/Commons/OfficeCard.jsx
@@ -25,7 +25,7 @@ const OfficeCard = ({
 }) => {
   const intl = useIntl();
   const Image = config.getComponent({ name: 'Image' }).component;
-  const showImage = contentHasImage(office, showimage);
+  const showImage = showimage && contentHasImage(office);
 
   return (
     <div

diff --git a/src/helpers/images.js b/src/helpers/images.js