This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
This changes dependencies from ReactiveCocoa 2.x to ReactiveObjC 2.1.x #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
reviewed
Dec 21, 2016
ReactiveViewModel.podspec.json
Outdated
| ] | ||
| }, | ||
| "prepare_command": "find . \\( -regex '.*EXT.*\\.[mh]$' -o -regex '.*metamacros\\.[mh]$' \\) -execdir mv {} RAC{} \\;\nfind . -regex '.*\\.[hm]' -exec sed -i '' -E 's@\"(EXT.*|metamacros)\\.h\"@\"RAC\\1.h\"@' {} \\;\nfind . -regex '.*\\.[hm]' -exec sed -i '' -E 's@<ReactiveObjC/(EXT.*)\\.h>@<ReactiveObjC/RAC\\1.h>@' {} \\;\n" | ||
| } |
There was a problem hiding this comment.
Would this podspec need to be pushed somewhere? Or is inclusion in this repo enough?
I'm not sure who maintains the podspec.
The rest of this PR is great.
There was a problem hiding this comment.
I found this podspec here and updated it.
I don't know right way to upgrade it to new version too 😕
There was a problem hiding this comment.
Would you mind splitting the podspec change into a separate PR?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.