Line ending options #130
Closed
Line ending options #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@takluyver #131 contains a proof of concept how to do this without extra options. |
|
@takluyver I think this should be done on fissix, also closing in favour of #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121, alternative to #129.
This is slightly less efficient than the approach in #129, because the file is re-read and re-written, but it doesn't involve monkeypatching anything, so it's more robust. Given that the parsing and refactoring machinery is already an order of magnitude slower than reading/writing files, I think the more robust approach is preferable.
This uses a subclass of StdoutRefactoringTool. If the line endings were specified, after a file is written by 2to3, we immediately read it again and rewrite it with the specified newlines.