Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Fix deprecation message link #2220

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Jan 4, 2024

The following warning message was outputting a link that was not valid, so it has been corrected to a valid link.

/Users/yasuhisa.yoshida/.cache/pre-commit/repoclpuwaei/py_env-python3.10/lib/python3.10/site-packages/isort/settings.py:343: UserWarning: A custom settings file was specified: /Users/yasuhisa.yoshida/my_project/pyproject.toml but no configuration was found inside. This can happen when [settings] is used as the config header instead of [isort]. See: https://pycqa.github.io/isort/docs/configuration/config_files/#custom_config_files for more information.
  warn(

@syou6162
Copy link
Contributor Author

@staticdev Could you review this pull request?

@syou6162
Copy link
Contributor Author

@bp72 Thank you for reviewing!

@staticdev Could you merge this pull request?

isort/settings.py Outdated Show resolved Hide resolved
Co-authored-by: Daniël van Noord <[email protected]>
@syou6162 syou6162 requested a review from DanielNoord January 14, 2025 20:47
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (bced410) to head (178fb00).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          40       40           
  Lines        3096     3096           
  Branches      787      787           
=======================================
  Hits         3069     3069           
  Misses         15       15           
  Partials       12       12           

Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @syou6162 LGTM.

@staticdev staticdev merged commit 86485e2 into PyCQA:main Jan 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants