Fix nosec for nested dicts #1004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit nosec was searched from the begnning
of the expression's context, which may be broader than
the exact piece of code that a developer wants to skip.
This caused, that for the below example:
1. example = {
2. 'S3_CONFIG_PARAMS': dict( # nosec B106
3. ...
4. ),
5. 'LOCALFS_BASEDIR': '/var/tmp/herp', # nosec B108
6. }
for line 5, nosec from line 2 was returned. Thus `nosec B108` was ignored.
This commit changes the algorithm that search for nosec for an expression
and nosec from the exact line of the expression is preferred.
Resolves: PyCQA#1003
kfrydel
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit nosec was searched from the begnning of the expression's context, which may be broader than the exact piece of code that a developer wants to skip. This caused, that for the below example:
for line 5, nosec from line 2 was returned. Thus
nosec B108was ignored.This commit changes the algorithm that search for nosec for an expression and nosec from the exact line of the expression is preferred.
Resolves: #1003